Finish code tree building, fix password in dialogs, merge macOS build fixes #143
Conversation
…import() ressource lines in addressbook/interface
…s as the idl definition file directly depends on mivExchangeAbCard.idl
…as it imports exchangeAbFunctions.js and it runs GAL (Global Address List) search
… manifest Manifest files can create only one reference by namespace, so I had to use another namespace than exchangecalendar. To keep it simple, I've decided to use exchangeaddress namespace so the user can directly that's related to our Exchange plugin and to the addressbook part
…rbird globasl search index will affect features
…e relies on spaces inside XML inner values (checkout file from commit 5fe104)
This avoids modifying source-controlled files from build. This also avoids use of nonstandard -i option (whose backup-less form differs between the GNU version and the BSD/macOS version).
The source is one of the two update_*.txt files. Create unconditionally, because the $(update) value may change from time to time and there is no way to determine if it has changed.
This is to avoid repetition and, in turn, copy-and-paste glitches later.
Without this, if make were re-run after removing a source file from the repository, the removed file would not be retired out of the XPI file, causing confusion.
This is because install.rdf is no longer source-controlled.
Taking the current directory when no path is given is a GNU extension and breaks macOS builds.
…ead of URI.password According to the nsIURI documentation, this should change nothing, but in practice it fixes our issues like Ericsson#103
…e-move-calendarevent
Trim
changed the title
😱 |
|
Ok, I looked through the structure and it appears to be in much better shape than before. Thanks a lot for all your work! Unfortunately I don't have the time to check if the code still works (too bad there aren't any tests), so merging will be on good faith basis once again. However, with one more beta release there should be opportunity to catch obvious regressions. |
|
@Trim Would you be able to update the CHANGELOG file with all the PRs that have been merged since beta4? Also, there are some new locales that were added on Transifex that might still need integration. Since those only have 0% translated, I'm not sure what the process is there. I'll try to get a new beta release out once things are ready. |
|
Cool, thanks for the merge 👍 Yes, I'm updating the CHANGELOG and I'll push and get new translations from Transifex. |
Finally, I took times to rebuild the code tree according to issue #80
While doing tests, I think I've found a workaround for issues like #103
I've took also the opportunity to merge and test directly PR #142 to fix build on macOS and create always new file archive (thanks to @astralblue).
Sorry for that such big PRs, I hope it will be the last huge PR to move and modify enverything in the repo :/
PS: These PRs are merged too with this pull request: #142 #135 #133 #122 #120 #119