This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
cleanup code by removing exchService-common-sets.js #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code were overriding the one in comm-central repo (file calendar/base/content/calendar-item-editing.js). It didn't follow the latest development of Lightning (5.7) and it didn't add anything used inside the Exchange Calendar plugin. Furthermore, removing it benefits to users too, because since Thunderbird 52 release, users can now create (and modify) events (and tasks) in a tab instead of a dialog window.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code were overriding the one in comm-central repo (file calendar/base/content/calendar-item-editing.js).
It didn't follow the latest development of Lightning (5.7) and it didn't add anything used inside the Exchange Calendar plugin.
Furthermore, removing it benefits to users too, because since Thunderbird 52 release, users can now create (and modify) events (and tasks) in a tab instead of a dialog window.