Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Upgrade the console messages to redirect to the ExchangeCalendar Github #92

Merged

Conversation

bbbco
Copy link

@bbbco bbbco commented Sep 19, 2017

Upgrade the console messages to redirect to the ExchangeCalendar Github page instead of Ericsson.

This was one of the requests made by #90

@advancingu advancingu changed the base branch from master to ec-4.0 September 19, 2017 19:18
@advancingu
Copy link
Member

Hi @bbbco, thanks for the PR.
The target branch for the next release is ec-4.0 which I now changed here. Can you please resolve the conflict and check that there are no new logs in this branch that reference the old repository?

@bbbco
Copy link
Author

bbbco commented Sep 19, 2017

I checked that there are no new logs in the ec-4.0 branch, and I can confirm that I did not find any other logs.

However, there is a reference to ericsson that does concern me on line 252 in chrome/content/adutils.js regarding the searchUser() function which hard-codes the ericsson DC if gLdapOperation is true:

    getLDAPOperation();
    if(gLdapOperation)
    {
    	gLdapOperation.searchExt("DC=ericsson,DC=se", gLdapServerURL.scope, searchString, wantedAttribs, 0, maxEntriesWanted);
    }

Is this kosher?

@advancingu
Copy link
Member

This looks odd. Without having looked at the context where this is used, I would not expect hardcoded data in an LDAP lookup. Can you please open an issue about this?
The changes here are good to merge.

@advancingu advancingu merged commit c111390 into ExchangeCalendar:ec-4.0 Sep 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants