Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace http with https #11

Merged
merged 1 commit into from
Nov 9, 2020
Merged

feat: replace http with https #11

merged 1 commit into from
Nov 9, 2020

Conversation

krrprr
Copy link
Contributor

@krrprr krrprr commented Oct 27, 2020

First step in resolving ExchangeUnion/xud-ui#26:
Enable https

@krrprr krrprr requested a review from reliveyy October 27, 2020 13:28
@krrprr krrprr self-assigned this Oct 27, 2020
@kilrau kilrau requested a review from raladev October 27, 2020 16:58
Dockerfile Outdated
Comment on lines 11 to 12
COPY ./cmd/proxy/cert.sh .
RUN apk add --update openssl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krrprr Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Created a PR for that @reliveyy

Dockerfile Outdated
Comment on lines 11 to 12
COPY ./cmd/proxy/cert.sh .
RUN apk add --update openssl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krrprr Yes

@kilrau kilrau added the P2 mid priority label Nov 6, 2020
@raladev raladev merged commit 305c343 into master Nov 9, 2020
@krrprr krrprr deleted the feat/https branch November 9, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 mid priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants