Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KeyError when retrieving Labels #814

Merged
1 commit merged into from
Dec 8, 2020
Merged

fix: KeyError when retrieving Labels #814

1 commit merged into from
Dec 8, 2020

Conversation

reliveyy
Copy link
Collaborator

@reliveyy reliveyy commented Dec 8, 2020

This is a hotfix for ARM when the error below happens

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/__init__.py", line 281, in launch
    env.start()
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/__init__.py", line 250, in start
    up_env = self.node_manager.update()
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/node/__init__.py", line 233, in update
    images = self.image_manager.check_for_updates()
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/node/image.py", line 178, in check_for_updates
    use, pull = f.result()
  File "/usr/local/lib/python3.8/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/usr/local/lib/python3.8/concurrent/futures/_base.py", line 388, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/node/image.py", line 136, in _check_image
    cloud = self._get_cloud_image(image)
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/node/image.py", line 122, in _get_cloud_image
    image = self.dockerutil.get_image(name)
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/docker/core.py", line 77, in get_image
    return self._get_registry_image(name)
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/docker/core.py", line 128, in _get_registry_image
    return self._handle_v2_manifest(canonical_name, payload)
  File "/usr/local/lib/python3.8/site-packages/launcher-1.0.0-py3.8.egg/launcher/docker/core.py", line 159, in _handle_v2_manifest
    labels=blob["config"]["Labels"] or {},
KeyError: 'Labels'

@reliveyy reliveyy requested review from a user, kilrau and raladev December 8, 2020 14:24
@reliveyy reliveyy self-assigned this Dec 8, 2020
@ghost ghost merged commit 5c2f054 into master Dec 8, 2020
@ghost ghost deleted the fix-key-error branch December 8, 2020 14:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant