Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boltz image after breaking gRPC changes #822

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Conversation

michael1011
Copy link
Contributor

@michael1011 michael1011 commented Dec 12, 2020

This PR fixes the boltz-lnd integration because it was broken in the latest couple commits merged into master. These commits:

  • added TLS to the gRPC interface
  • added macaroon authentication to the gRPC interface
  • added a REST proxy for the gRPC interface

Todo:

  • add --datadir argument for boltzd and boltzcli to make specifying the base directory to which boltzd writes files easier will be done in a separate PR
  • fix existing environments that were bricked with the new image

@michael1011 michael1011 requested a review from reliveyy December 12, 2020 12:30
@kilrau kilrau added the P1 top priority label Dec 14, 2020
@kilrau
Copy link
Contributor

kilrau commented Dec 14, 2020

R4R @reliveyy @raladev

@kilrau kilrau marked this pull request as ready for review December 14, 2020 11:31
@kilrau kilrau merged commit a1f8efa into master Dec 14, 2020
@michael1011 michael1011 deleted the fix-latest-boltz branch December 14, 2020 22:50
raladev added a commit that referenced this pull request Dec 15, 2020
* chore: use node lts (#820)

This updates node versions to use lts instead of hardcoding at v12. Lts
is currently v14 which supports ES2020 language features like `bigint`.

* fix: boltz image after breaking gRPC changes (#822)

* fix: boltz image after breaking gRPC changes

* fix: recreate boltz config of existing environments

* chore: bump boltz mainnet version to v1.2.0

Co-authored-by: Daniel McNally <[email protected]>
Co-authored-by: michael1011 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 top priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants