Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens Recognition for Yongnuo YN 35mm f/2 #2902

Closed
tuxfanx opened this issue Jan 23, 2024 · 4 comments
Closed

Lens Recognition for Yongnuo YN 35mm f/2 #2902

tuxfanx opened this issue Jan 23, 2024 · 4 comments
Labels
good first issue request feature request or any other kind of wish

Comments

@tuxfanx
Copy link

tuxfanx commented Jan 23, 2024

Is your feature request related to a problem?

exiv2 doesn't recognize the lens Yongnuo YN 35mm f/2.
The lens is recognized by exiftool as Yongnuo YN 35mm f/2 and is included in the lensfun database under this name.

Describe the solution you would like

Would be wonderful, if you may add recognition of this lens to exiv2.

Describe alternatives you have considered

As a work-around I created an exiv2.ini

Desktop

  • OS: Debian bookworm
  • Exiv2 version and source: 0.27.6 and 1.00.0.9
  • Any software using exiv2 and source: darktable 4.6.0

Additional context

I attached a jpeg picture taken with Canon EOS 5D Mark II. The lens is also available with a Nikon F mount

IMG_5121

@tuxfanx tuxfanx added the request feature request or any other kind of wish label Jan 23, 2024
@kmilos
Copy link
Collaborator

kmilos commented Jan 23, 2024

Seems to be present in the Canon tables already: https://github.com/Exiv2/exiv2/blob/v0.27.6/src/canonmn_int.cpp#L1900

As there are several lenses w/ this ID, it's possible that dealiasing for Canon is/was broken. Please search the issues, there are several similar reports about this.

For Nikon, a separate sample is needed.

@kmilos
Copy link
Collaborator

kmilos commented Jan 23, 2024

Also, I don't see the problem on this sample w/ exiv2 0.28.1:

Exif.CanonCs.LensType                         198  Yongnuo YN 35mm f/2

@tuxfanx
Copy link
Author

tuxfanx commented Jan 23, 2024

Thanks for the info!
Unfortunately, I can't provide a picture for Nikon mount.

@tuxfanx tuxfanx closed this as completed Jan 23, 2024
@kmilos
Copy link
Collaborator

kmilos commented Jan 24, 2024

FYI: #2904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue request feature request or any other kind of wish
Projects
None yet
Development

No branches or pull requests

2 participants