Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Yongnuo and Zeiss lenses for Nikon F #2904

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 24, 2024

Using exiftool tables and some samples from web search.

@ghost
Copy link

ghost commented Jan 24, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57d9d2f) 63.90% compared to head (6899886) 63.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2904   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         104      104           
  Lines       22389    22389           
  Branches    10876    10876           
=======================================
  Hits        14308    14308           
  Misses       5857     5857           
  Partials     2224     2224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos kmilos marked this pull request as draft January 24, 2024 14:56
@kmilos kmilos marked this pull request as ready for review January 24, 2024 15:08
@kmilos kmilos added the lens Issue related to lens detection label Jan 24, 2024
@kmilos kmilos merged commit 501770a into main Jan 25, 2024
64 checks passed
@kmilos kmilos deleted the kmilos/nikon_f_lens_yz branch January 25, 2024 06:16
@kmilos
Copy link
Collaborator Author

kmilos commented Jan 25, 2024

@mergify backport 0.28.x

Copy link
Contributor

mergify bot commented Jan 25, 2024

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants