replace reinterpret_cast with memcpy #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cast-align warning on 32-bit. Signed-off-by: Rosen Penev <[email protected]>
|
interesting. this is the only usage of guess that's bad. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2896 +/- ##
=======================================
Coverage 63.90% 63.90%
=======================================
Files 104 104
Lines 22389 22389
Branches 10876 10876
=======================================
Hits 14308 14308
Misses 5857 5857
Partials 2224 2224 ☔ View full report in Codecov by Sentry. |
These usages are not problematic, but they would be if alignment does not match. Also less verbose. Signed-off-by: Rosen Penev <[email protected]>
They are equivalent. Signed-off-by: Rosen Penev <[email protected]>
No longer relevant. Signed-off-by: Rosen Penev <[email protected]>
kmilos
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cast-align warning on 32-bit.