This repository has been archived by the owner on Sep 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed a potential issue in the code where the regional site effect parameters might not be incorporated into the PGA formula. This is fixed by 8a9f0ad
Currently, the parameter seems to default to 1.751.
If this observation is correct, it could potentially lead to less precise seismic response calculations for various regions.
I believe integrating specific site effect parameters for each area could enhance the accuracy of our earthquake impact assessments.
TREM-tauri/src/scripts/helper/utils.ts
Lines 200 to 208 in 8a9f0ad
There's also a small optimization: 009c666
We can use the intensity map to get local intensity without re-calculation.