Skip to content

Commit

Permalink
fix: Upgraded protobuf version (4.24.0 has issue - seg fault)
Browse files Browse the repository at this point in the history
  • Loading branch information
Bhargav Dodla committed Jun 27, 2024
1 parent 9932408 commit 478eb64
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 13 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ install-go-ci-dependencies:
# The `go get` command on the previous lines download the lib along with replacing the dep to `feast-dev/gopy`
# but the following command is needed to install it for some reason.
go install github.com/go-python/gopy
python -m pip install "pybindgen==0.22.1" "protobuf<5,>3.20"
python -m pip install "pybindgen==0.22.1" "protobuf>=4.24.0,<5"

install-protoc-dependencies:
pip install --ignore-installed "protobuf>=4.24.0,<5" "grpcio-tools>=1.56.2,<2" mypy-protobuf==3.1.0
Expand All @@ -425,7 +425,7 @@ install-feast-ci-locally:
# Needs feast package to setup the feature store
# CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag
test-go: compile-protos-go compile-protos-python compile-go-lib install-feast-ci-locally
CGO_LDFLAGS_ALLOW=".*" go test -v -tags cgo,ccalloc ./...
CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./...

format-go:
gofmt -s -w go/
Expand Down
15 changes: 4 additions & 11 deletions go/internal/test/go_integration_test_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func GetLatestFeatures(Rows []*Row, entities map[int64]bool) map[int64]*Row {
}

func SetupCleanFeatureRepo(basePath string) error {
fmt.Println("Running feast init")
cmd := exec.Command("feast", "init", "my_project")
path, err := filepath.Abs(basePath)
cmd.Env = os.Environ()
Expand All @@ -101,22 +100,17 @@ func SetupCleanFeatureRepo(basePath string) error {
if err != nil {
return err
}
fmt.Println("Completed feast init")
applyCommand := exec.Command("feast", "apply")
applyCommand.Env = os.Environ()
featureRepoPath, err := filepath.Abs(filepath.Join(path, "my_project", "feature_repo"))
if err != nil {
return err
}
applyCommand.Dir = featureRepoPath
fmt.Println("Running feast apply with RepoPath: ", featureRepoPath)
output, err1 := applyCommand.Output()
fmt.Println("Output of Feast apply: ", string(output))
if err1 != nil {
log.Fatal(err1)
return err1
}
fmt.Println("Completed feast apply")
err = applyCommand.Run()
if err != nil {
return err
}
t := time.Now()

formattedTime := fmt.Sprintf("%d-%02d-%02dT%02d:%02d:%02d",
Expand All @@ -129,7 +123,6 @@ func SetupCleanFeatureRepo(basePath string) error {
if err != nil {
return err
}
fmt.Println("Completed feast materialize")
return nil
}

Expand Down

0 comments on commit 478eb64

Please sign in to comment.