Skip to content

Commit

Permalink
fix: Limiting the keyBatchSize max to 100
Browse files Browse the repository at this point in the history
Limiting the keyBatchSize max to 100 since maximum clustering-key cartesian product size is 100
  • Loading branch information
vanitabhagwat authored Jan 24, 2025
1 parent e4ca438 commit 7f9427e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go/internal/feast/onlinestore/cassandraonlinestore.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ func NewCassandraOnlineStore(project string, config *registry.RepoConfig, online
}
store.session = createdSession

if cassandraConfig.keyBatchSize <= 0 {
return nil, fmt.Errorf("key_batch_size must be greater than zero")
if cassandraConfig.keyBatchSize <= 0 || cassandraConfig.keyBatchSize > 100 {
return nil, fmt.Errorf("key_batch_size must be greater than zero and less than 100")
} else if cassandraConfig.keyBatchSize == 1 {
log.Info().Msg("key batching is disabled")
} else {
Expand Down

0 comments on commit 7f9427e

Please sign in to comment.