feat: Update pymilvus to 2.4.x #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…milvus to differentiate from the opensource implementation
EXPEbdodla
reviewed
Nov 1, 2024
| @@ -1,12 +1,12 @@ | |||
| FROM python:3.11-slim | |||
|
|
|||
| RUN python3 -m pip install milvus==2.2.12 | |||
| RUN python3 -m pip install milvus==2.4.13 | |||
There was a problem hiding this comment.
You can use VERSION as ARG so going forward you can change at one place.
EXPEbdodla
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the pymilvus SDK to the latest version to be compatible with the current milvus version (2.4.x)
Additionally, this renames the expediagroup milvus implementation to eg-milvus to differentiate from the opensource version (still in alpha) so we can avoid any potential conflicts.
Which issue(s) this PR fixes:
Without the SDK upgrade, milvus operations fail against the updated milvus clusters.