fix: Using BatchStatement instead of execute_concurrent_with_args #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabarn
reviewed
Jan 7, 2025
Comment on lines
505
to
534
| futures = [] | ||
| for batch in batches: | ||
| futures.append(session.execute_async(batch)) | ||
| if len(futures) >= config.online_store.write_concurrency: | ||
| # Raises exception if at least one of the batch fails | ||
| try: | ||
| for future in futures: | ||
| future.result() | ||
| futures = [] | ||
| except Exception as exc: | ||
| logger.error(f"Error writing a batch: {exc}") | ||
| print(f"Error writing a batch: {exc}") | ||
| raise Exception("Error writing a batch") from exc | ||
|
|
||
| if len(futures) > 0: | ||
| try: | ||
| for future in futures: | ||
| future.result() | ||
| futures = [] | ||
| except Exception as exc: | ||
| logger.error(f"Error writing a batch: {exc}") | ||
| print(f"Error writing a batch: {exc}") | ||
| raise Exception("Error writing a batch") from exc | ||
|
|
||
| # execute_concurrent_with_args( | ||
| # session, | ||
| # insert_cql, | ||
| # rows, | ||
| # concurrency=config.online_store.write_concurrency, | ||
| # ) |
There was a problem hiding this comment.
This no longer allows for write_concurrency to be set in the feature_store.yaml then, right?
There was a problem hiding this comment.
Still using that. Refer Line feast-dev#508
EXPEbdodla
force-pushed
the
use_batch
branch
3 times, most recently
from
01e6130 to
075c4c0
Compare
EXPEbdodla
force-pushed
the
use_batch
branch
2 times, most recently
from
a0d66f2 to
c535a17
Compare
EXPEbdodla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix: Using BatchStatement instead of execute_concurrent_with_args
Which issue(s) this PR fixes:
mapInPandas()online_store_to override online store configurations. Not all online store configurations are overridden.Misc