accepting client_id header #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXPEbdodla
requested changes
Feb 1, 2024
| @@ -61,6 +61,8 @@ class HttpRegistryConfig(RegistryConfig): | |||
| """ str: Endpoint of Feature registry. | |||
| If registry_type is 'http', then this is a endpoint of Feature Registry """ | |||
|
|
|||
| clint_id: Optional[StrictStr] = "Unknown" | |||
| @@ -77,6 +79,7 @@ def __init__( | |||
| timeout = httpx.Timeout(5.0, connect=60.0) | |||
| transport = httpx.HTTPTransport(retries=3, verify=False) | |||
| self.base_url = registry_config.path | |||
| self.client_id = registry_config.clint_id | |||
There was a problem hiding this comment.
Update self.http_client with the client_id. That should suffice the need. No need to pass from each function.
added 2 commits
February 1, 2024 15:29
EXPEbdodla
approved these changes
Feb 1, 2024
added 3 commits
February 1, 2024 15:52
EXPEbdodla
approved these changes
Feb 2, 2024
added 2 commits
February 1, 2024 22:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is adding client_id to http registry request headers and accepting the client_id in config.
It helps tracking the requests to registry.