Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding client id for tracking requests to registry #84

Merged
merged 15 commits into from
Feb 26, 2024

Conversation

vanitabhagwat
Copy link
Collaborator

@vanitabhagwat vanitabhagwat commented Feb 19, 2024

What this PR does / why we need it:
feat: Adding client id for tracking requests to registry

Which issue(s) this PR fixes:
feat: Adding client id for tracking requests to registry
Fixes #

@vanitabhagwat vanitabhagwat changed the title adding client id for tracking requests to registry feat: adding client id for tracking requests to registry Feb 19, 2024
@wparsley-eg
Copy link

Couple questions:

  1. How does the client input their ID? Is this being populated from the HTTP headers?
  2. How is this being persisted? Are we logging the ClientID, or storing it in the registry?

Otherwise, looks fine - would like a test case or two here to show coverage.

@vanitabhagwat
Copy link
Collaborator Author

Couple questions:

  1. How does the client input their ID? Is this being populated from the HTTP headers?
  2. How is this being persisted? Are we logging the ClientID, or storing it in the registry?

Otherwise, looks fine - would like a test case or two here to show coverage.

  1. Clients will configure the ID in their feature_store.yaml. Currently making that change to ml-workflow.
  2. It would be added to the request traces in eg-feature-store-registry.

I will work on adding the test cases.

@vanitabhagwat vanitabhagwat merged commit 5e7271d into master Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants