Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Fix: Optimize client creation #42

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Fix: Optimize client creation #42

merged 1 commit into from
Jul 9, 2020

Conversation

tuckbick
Copy link
Member

@tuckbick tuckbick commented Jul 8, 2020

Description

When creating a client that was already cached, some unnecessary configuration merging was occurring. This PR refactors the code to avoid this.

How Has This Been Tested?

Yes, existing tests should confirm that the refactoring does not change behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tuckbick tuckbick self-assigned this Jul 8, 2020
ianwhitedeveloper
ianwhitedeveloper approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@ianwhitedeveloper ianwhitedeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tuckbick tuckbick merged commit d4a5b5e into master Jul 9, 2020
@tuckbick tuckbick deleted the optimize-create branch July 9, 2020 16:11
cmoody
cmoody approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@cmoody cmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmoody cmoody cmoody approved these changes

@ianwhitedeveloper ianwhitedeveloper ianwhitedeveloper approved these changes

@smilebot smilebot Awaiting requested review from smilebot

Assignees

@tuckbick tuckbick

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuckbick @cmoody @ianwhitedeveloper