Stop Stream Creation for existing topics if configs don't match #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neoword
suggested changes
Dec 17, 2018
core/src/main/java/com/homeaway/streamingplatform/db/dao/impl/KafkaManagerImpl.java
Outdated
Show resolved
Hide resolved
arunvasudevan
changed the title
|
Not sure I understand the need for this given work that is being done elsewhere. |
arunvasudevan
commented
Dec 20, 2018
core/src/main/java/com/homeaway/streamingplatform/db/dao/KafkaManager.java
Show resolved
Hide resolved
core/src/main/java/com/homeaway/streamingplatform/db/dao/impl/KafkaManagerImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/homeaway/streamingplatform/db/dao/impl/KafkaManagerImpl.java
Outdated
Show resolved
Hide resolved
neoword
suggested changes
Dec 20, 2018
core/src/main/java/com/homeaway/streamingplatform/db/dao/impl/KafkaManagerImpl.java
Show resolved
Hide resolved
neoword
suggested changes
Dec 20, 2018
CHANGELOG.md
Outdated
| @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ### Added | |||
| - Schema validation support via `SchemaManager` interface with default Confluent implementation provided (#41) | |||
|
|
|||
| ### Changed | |||
| - Stop Stream Creation for existing topics if topic configs don't match | |||
|
|
|||
There was a problem hiding this comment.
this is being targetted for 0.4.2
- Still need to fix all FIXMEs - Need to get unit test working properly
CodeReview Updates
neoword
approved these changes
Jan 3, 2019
neoword
pushed a commit
that referenced
this pull request
Jan 16, 2019
* Removed unused retrofit library (#70) * Removed unused retrofit library * Favor mvn exec rather than java jar (#68) * Fix 'make run' (#76) * Dockerize (#74) * Dockerize * Update CHANGELOG.md * [maven-release-plugin] prepare release v0.4.1 * [maven-release-plugin] prepare for next development iteration * Updated changelog (should have done before tag) * Fixed changelog date 0.4.1 * Stop Stream Creation for existing topics if configs don't match (#52) * Removing update topics functionality in Stream Registry * Stop Stream Creation for existing topics if configs don't match * Adding more tests to be comprehensive * Updating comments * Updating changelog to version 0.4.2 * Adding arch diagram to fix #4 (#80) * Adding arch diagram to fix #4 * Updating CHANGELOG.md * Decouple infra-provider from core (#78) * Decouple infra-provider from core * Update CHANGELOG.md * Enforce SLF4J (#82) * Adding architecture picture to arch documentation * Bug/delete client error fix (#73) * Consumer and producer delete methods bug fix * Package re-order * Changelog update * Jordan's suggestions * package name cleanup (#85) * moved java packages to com.homeaway.streamingplatform.streamregistry * updated for issue #16 * moved java packages to com.homeaway.streamplatform.streamregistry
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream-registry PR
Check if the topic configs as part of the new stream are same as that of the existing topics config. If the configs don't match throw Stream Creation Exception.
Added
Changed
Deleted
PR Checklist Forms