Adding build and runtime support for open jdk 11 #71
Conversation
* Removed unused retrofit library
|
nice! reviewing now. |
Makefile
Outdated
| @@ -13,7 +13,7 @@ build: | |||
| ./mvnw clean install -B | |||
|
|
|||
| run: | |||
| java -Xmx2G -server -XX:+UseG1GC -XX:MaxGCPauseMillis=20 -XX:InitiatingHeapOccupancyPercent=35 -XX:+ExplicitGCInvokesConcurrent -Djava.awt.headless=true -jar assembly/target/stream-registry*SNAPSHOT.jar server config-dev.yaml | |||
| java --add-opens java.base/java.lang=ALL-UNNAMED -Xmx2G -server -XX:+UseG1GC -XX:MaxGCPauseMillis=20 -XX:InitiatingHeapOccupancyPercent=35 -XX:+ExplicitGCInvokesConcurrent -Djava.awt.headless=true -jar assembly/target/stream-registry*SNAPSHOT.jar server config-dev.yaml | |||
There was a problem hiding this comment.
Might want to leave a comment or reference for others in a breadcrumb comment
There was a problem hiding this comment.
along with instructions of what to add when we target jdk11 runtime (vs jdk8 runtime)
There was a problem hiding this comment.
Needs a rebase. The run command no longer looks like this
https://github.com/homeaway/stream-registry/blob/master/Makefile#L20-L21
There was a problem hiding this comment.
Re-based saketanisha:openjdk11 with homeaway:master. As part of the merge updated STREAM_REGISTRY_JAVA_OPTS and STREAM_REGISTRY_DEBUG_OPTS in Makefile with appropriate JDK flag ( i.e. --add-opens java.base/java.lang=ALL-UNNAMED )
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <scope>runtime</scope> | ||
| </dependency> |
There was a problem hiding this comment.
can we specify this scope at the parent level?
There was a problem hiding this comment.
also.. since this was deprecated in jdk9 doesn't this mean the jdk runtime will not supply it anymore?
If we are expecting this at runtime should we add a --add_modules to startup scripts?
https://blog.codefx.org/java/five-command-line-options-hack-java-module-system/
There was a problem hiding this comment.
Previous comment (--add_modules) ... disregard.
We still want to target JDK8 runtime for now for clients that haven't switched to JDK11. We will likely fix this when we switch to JDK11 target runtime in some future release.
There was a problem hiding this comment.
Moved <scope>runtime</scope> to parent pom.xml
core/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.ow2.asm</groupId> | ||
| <artifactId>asm</artifactId> | ||
| <version>7.0</version> |
There was a problem hiding this comment.
7.0 is repeated a lot. Can we make it a property?
There was a problem hiding this comment.
Moved to asm.version property.
There was a problem hiding this comment.
where's the change ? ${asm.version}
core/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.ow2.asm</groupId> | ||
| <artifactId>asm</artifactId> | ||
| <version>7.0</version> |
There was a problem hiding this comment.
where's the change ? ${asm.version}
|
Update CHANGELOG.md with the changes made in this PR. Please target a new milestone: |
stream-registry PR
Tweaked stream-registry base pom to build and run against Open JDK 11
Changed
pom.xmlwithjaxb-apidependencycore/pom.xmlto consumejaxb-apidependency at runtimepom.xml--add-opens java.base/java.lang=ALL-UNNAMEDoption to java command inMakefile. This is to alleviateIllegal reflective access by com.fasterxml.jackson.module.afterburner.util.MyClassLoader to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int). We may revisit this in near future once the underlying 3rd party libs extends support for JDK 11PR Checklist Forms