Address code review comments.

ExpediaGroup · Nov 14, 2018 · fad7bd1 · fad7bd1
1 parent f7f53aa
commit fad7bd1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/...ents/client/src/main/java/com/hotels/styx/client/connectionpool/SimpleConnectionPool.java b/...ents/client/src/main/java/com/hotels/styx/client/connectionpool/SimpleConnectionPool.java
@@ -100,7 +100,8 @@ Publisher<Connection> borrowConnection2() {
                     }
                 }
             }
-        }).timeout(Duration.ofMillis(poolSettings.pendingConnectionTimeoutMillis()),
+        }).timeout(
+                Duration.ofMillis(poolSettings.pendingConnectionTimeoutMillis()),
                 Mono.error(new MaxPendingConnectionTimeoutException(origin, connectionSettings.connectTimeoutMillis())));
     }
 

diff --git a/...nt/src/test/unit/java/com/hotels/styx/client/connectionpool/SimpleConnectionPoolTest.java b/...nt/src/test/unit/java/com/hotels/styx/client/connectionpool/SimpleConnectionPoolTest.java
@@ -117,7 +117,7 @@ public void borrowsReturnedConnection() {
 
 
     @Test
-    public void emitsConnectionWhenOnceEstablished() throws ExecutionException, InterruptedException {
+    public void emitsConnectionWhenOnceEstablished() {
         PublishSubject<Connection> subject = PublishSubject.create();
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
                 .thenReturn(subject);
@@ -293,7 +293,6 @@ public void unsubscribingRemovesTheWaitingSubscriber() throws ExecutionException
     }
 
 
-    // 2. The connection pool limits
     @Test
     public void limitsPendingConnectionsDueToConnectionEstablishment() {
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
@@ -307,8 +306,8 @@ public void limitsPendingConnectionsDueToConnectionEstablishment() {
 
         SimpleConnectionPool pool = new SimpleConnectionPool(origin, poolSettings, connectionFactory);
 
-        CompletableFuture<Connection> pending1 = Mono.from(pool.borrowConnection2()).toFuture();
-        CompletableFuture<Connection> pending2 = Mono.from(pool.borrowConnection2()).toFuture();
+        Mono.from(pool.borrowConnection2()).toFuture();
+        Mono.from(pool.borrowConnection2()).toFuture();
 
         StepVerifier.create(pool.borrowConnection2())
                 .expectError(MaxPendingConnectionsExceededException.class)
@@ -319,7 +318,6 @@ public void limitsPendingConnectionsDueToConnectionEstablishment() {
 
     }
 
-    // 2. The connection pool limits
     @Test
     public void limitsPendingConnectionsDueToPoolSaturation() {
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
@@ -362,7 +360,6 @@ public void limitsPendingConnectionsDueToPoolSaturation() {
     }
 
 
-    // 2. The connection pool limits
     @Test
     public void returnConnectionDecrementsConnectionCount() throws ExecutionException, InterruptedException, TimeoutException {
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
@@ -627,7 +624,7 @@ public void borrowRetriesThreeTimesOnConnectionEstablishmentFailure() {
     }
 
     @Test
-    public void connectionEstablishmentFailureRetryThreeTimesAtConnectionClosure() {
+    public void borrowRetriesThreeTimesOnFailureDueToConnectionClosure() {
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
                 .thenReturn(Observable.just(connection1))
                 .thenReturn(Observable.error(new OriginUnreachableException(origin, new RuntimeException())))
@@ -720,7 +717,7 @@ public void connectionEstablishmentFailureRetryThreeTimesOnlyAtConnectionClosure
     }
 
     @Test
-    public void pendingConnectionTimeout() {
+    public void emitsExceptionWhenPendingConnectionTimesOut() {
         PublishSubject<Connection> subject = PublishSubject.create();
         when(connectionFactory.createConnection(any(Origin.class), any(ConnectionSettings.class)))
                 .thenReturn(subject);