Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies 1.0 api #217

Merged
merged 26 commits into from
Jul 26, 2018
Merged

Cookies 1.0 api #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8c0d099
New classes
kvosper Jul 16, 2018
496d3bf
Move ServerCookieEncoder and use it
kvosper Jul 16, 2018
6ec463f
Use new API in HttpRequest
kvosper Jul 16, 2018
6efa49b
Use new API in FullHttpRequest
kvosper Jul 16, 2018
f2862c3
Use new cookies in responses
kvosper Jul 17, 2018
b703792
Remove old cookie class
kvosper Jul 17, 2018
c4f8e37
Remove HttpCookieAttribute class
kvosper Jul 18, 2018
3777c4d
Renamed RequestCookie.cookie to requestCookie to match naming scheme …
kvosper Jul 18, 2018
e2bcd7d
Tidy-up
kvosper Jul 18, 2018
9091fb6
Remove redundant method
kvosper Jul 18, 2018
10ed6dc
Tidy-up encoding/decoding
kvosper Jul 18, 2018
f6f46ff
Add some Javadoc
kvosper Jul 23, 2018
acb8b80
Add some Javadoc
kvosper Jul 23, 2018
a017204
Remove PseudoMap
kvosper Jul 23, 2018
1ba7b3f
Add more javadoc
kvosper Jul 23, 2018
161baac
Refactor
kvosper Jul 23, 2018
1c0762f
Tidy-up
kvosper Jul 23, 2018
e13efd0
Add+remove cookie methods
kvosper Jul 24, 2018
abcd425
Changes based on review comments
kvosper Jul 24, 2018
1f4616c
Add more tests
kvosper Jul 25, 2018
8830768
Add missing changes
kvosper Jul 25, 2018
5fb51a0
Add more tests
kvosper Jul 25, 2018
affb3e6
Test a new scenario
kvosper Jul 25, 2018
352735d
changes based on pr comments
kvosper Jul 25, 2018
098dc3c
Null-checks
kvosper Jul 26, 2018
0b7f3a7
Changes based on PR comments
kvosper Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions components/api/src/main/java/com/hotels/styx/api/FullHttpMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

import static com.hotels.styx.api.HttpHeaderNames.CONTENT_LENGTH;
import static com.hotels.styx.api.HttpHeaderNames.CONTENT_TYPE;
import static com.hotels.styx.api.support.CookiesSupport.findCookie;

/**
* All behaviour common to both full requests and full responses.
Expand All @@ -43,13 +42,6 @@ public interface FullHttpMessage {
*/
HttpHeaders headers();

/**
* Return all cookies in this response.
*
* @return all cookies.
*/
List<HttpCookie> cookies();

/**
* Returns the body of this message in its unencoded form.
*
Expand Down Expand Up @@ -89,16 +81,6 @@ default List<String> headers(CharSequence name) {
return headers().getAll(name);
}

/**
* Return the single cookie with the specified {@code name}.
*
* @param name cookie name
* @return the cookie if present
*/
default Optional<HttpCookie> cookie(String name) {
return findCookie(cookies(), name);
}

/**
* Return the {@code 'Content-Length'} header value.
*
Expand Down
Loading