-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make admin interfaces streamable #474
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
components/server/src/main/java/com/hotels/styx/server/AdminHttpRouter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| Copyright (C) 2013-2019 Expedia Inc. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| package com.hotels.styx.server; | ||
|
|
||
| import com.hotels.styx.api.Eventual; | ||
| import com.hotels.styx.api.HttpHandler; | ||
| import com.hotels.styx.api.HttpInterceptor; | ||
| import com.hotels.styx.api.LiveHttpRequest; | ||
| import com.hotels.styx.api.LiveHttpResponse; | ||
| import com.hotels.styx.api.WebServiceHandler; | ||
| import com.hotels.styx.common.http.handler.HttpAggregator; | ||
|
|
||
| import static com.hotels.styx.api.HttpResponse.response; | ||
| import static com.hotels.styx.api.HttpResponseStatus.NOT_FOUND; | ||
|
|
||
| /** | ||
| * Simple Http Router. | ||
| */ | ||
| public class AdminHttpRouter implements HttpHandler { | ||
| private static final int MEGABYTE = 1024 * 1024; | ||
| private static final HttpHandler NOT_FOUND_HANDLER = (request, context) -> Eventual.of(response(NOT_FOUND).build().stream()); | ||
|
|
||
| private final PathTrie<HttpHandler> routes = new PathTrie<>(); | ||
|
|
||
| @Override | ||
| public Eventual<LiveHttpResponse> handle(LiveHttpRequest request, HttpInterceptor.Context context) { | ||
| return routes.get(request.path()) | ||
| .orElse(NOT_FOUND_HANDLER) | ||
| .handle(request, context); | ||
| } | ||
|
|
||
| public AdminHttpRouter aggregate(String path, WebServiceHandler httpHandler) { | ||
| routes.put(path, new HttpAggregator(MEGABYTE, httpHandler)); | ||
| return this; | ||
| } | ||
|
|
||
| public AdminHttpRouter stream(String path, HttpHandler httpHandler) { | ||
| routes.put(path, httpHandler); | ||
| return this; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @taer Thank you for doing this! Very useful. But one comment.
Please move this class to
styx-proxymodule. This class is called AdminHttpRouter, and you are adding it to thestyx-servermodule which doesn't have an admin interface. The admin interface is in thestyx-proxy. Therefore it should live in the proxy module. But otherwise it good to go :-D.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. I think the test failure is a timeout based test