Skip to content

Commit

Permalink
Merge pull request #6172 from Expensify/cmartins-removeStepCounter
Browse files Browse the repository at this point in the history
Remove the step counter from "Let's finish in chat" step of VBA flow
  • Loading branch information
Joel Bettner authored Nov 3, 2021
2 parents 0841cc4 + 4ee7a86 commit 2281700
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
6 changes: 5 additions & 1 deletion src/components/HeaderWithCloseButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ const propTypes = {
/** Whether we should show a inbox call button */
shouldShowInboxCallButton: PropTypes.bool,

/** Whether we should show the step counter */
shouldShowStepCounter: PropTypes.bool,

/** The task ID to associate with the call button, if we show it */
inboxCallTaskID: PropTypes.string,

Expand All @@ -57,6 +60,7 @@ const defaultProps = {
shouldShowBorderBottom: false,
shouldShowDownloadButton: false,
shouldShowInboxCallButton: false,
shouldShowStepCounter: true,
inboxCallTaskID: '',
stepCounter: null,
};
Expand Down Expand Up @@ -84,7 +88,7 @@ const HeaderWithCloseButton = props => (
)}
<Header
title={props.title}
subtitle={props.stepCounter ? props.translate('stepCounter', props.stepCounter) : ''}
subtitle={props.stepCounter && props.shouldShowStepCounter ? props.translate('stepCounter', props.stepCounter) : ''}
/>
<View style={[styles.reportOptions, styles.flexRow, styles.pr5]}>
{
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ export default {
reviewingInfo: 'Thanks! We\'re reviewing your information, and will be in touch shortly. Please check your chat with Concierge ',
forNextSteps: ' for next steps to finish setting up your bank account.',
letsChatCTA: 'Yes, let\'s chat!',
letsChatText: 'Thanks for doing that! We have a couple more things to work out, but it’ll be easier over chat. Ready to chat?',
letsChatText: 'Thanks for doing that! We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?',
letsChatTitle: 'Let\'s chat!',
},
beneficialOwnersStep: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ export default {
reviewingInfo: '¡Gracias! Estamos revisando tu información y nos comunicaremos contigo en breve. Consulte su chat con Concierge ',
forNextSteps: ' para conocer los próximos pasos para terminar de configurar su cuenta bancaria.',
letsChatCTA: '¡Sí, vamos a chatear!',
letsChatText: '¡Gracias! Todavía tenemos que solucionar un par de cosas, pero será más fácil por chat. ¿Listo para charlar?',
letsChatText: '¡Gracias! Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',
letsChatTitle: '¡Vamos a chatear!',
},
beneficialOwnersStep: {
Expand Down
1 change: 1 addition & 0 deletions src/pages/ReimbursementAccount/ValidationStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ class ValidationStep extends React.Component {
onCloseButtonPress={Navigation.dismissModal}
onBackButtonPress={() => Navigation.goBack()}
shouldShowBackButton
shouldShowStepCounter={!isVerifying}
/>
{maxAttemptsReached && (
<View style={[styles.m5, styles.flex1]}>
Expand Down

0 comments on commit 2281700

Please sign in to comment.