Change usage of boolean prop name

Expensify · Feb 8, 2022 · 2298ebc · 2298ebc
1 parent 9de73c1
commit 2298ebc
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 12 deletions.
diff --git a/src/components/KYCWall/BaseKYCWall.js b/src/components/KYCWall/BaseKYCWall.js
@@ -34,7 +34,7 @@ class KYCWall extends React.Component {
     }
 
     componentWillUnmount() {
-        if (this.props.listenResize) {
+        if (this.props.shouldListenForResize) {
             window.removeEventListener('resize', null);
         }
         PaymentMethods.kycWallRef.current = null;
@@ -63,7 +63,6 @@ class KYCWall extends React.Component {
      *
      * @param {Object} position
      */
-
     setPositionAddPaymentMenu(position) {
         this.setState({
             anchorPositionTop: position.anchorPositionTop,
@@ -84,7 +83,7 @@ class KYCWall extends React.Component {
             Log.info('[KYC Wallet] User does not have valid payment method');
             let clickedElementLocation = getClickedElementLocation(event.nativeEvent);
             let position = this.getAnchorPosition(clickedElementLocation);
-            if (this.props.listenResize) {
+            if (this.props.shouldListenForResize) {
                 window.addEventListener('resize', () => {
                     clickedElementLocation = getClickedElementLocation(event.nativeEvent);
                     position = this.getAnchorPosition(clickedElementLocation);

diff --git a/src/components/KYCWall/index.js b/src/components/KYCWall/index.js
@@ -4,7 +4,7 @@ import BaseKYCWall from './BaseKYCWall';
 
 const KYCWall = props => (
     // eslint-disable-next-line react/jsx-props-no-spreading
-    <BaseKYCWall {...props} listenResize />
+    <BaseKYCWall {...props} shouldListenForResize />
 );
 
 KYCWall.propTypes = propTypes;

diff --git a/src/components/KYCWall/kycWallPropTypes.js b/src/components/KYCWall/kycWallPropTypes.js
@@ -15,7 +15,7 @@ const propTypes = {
     popoverPlacement: PropTypes.string,
 
     /** Listen for window resize event on web and desktop */
-    listenResize: PropTypes.bool,
+    shouldListenForResize: PropTypes.bool,
 
     ...userWalletPropTypes,
 };
@@ -24,7 +24,7 @@ const defaultProps = {
     // eslint-disable-next-line react/default-props-match-prop-types
     userWallet: {},
     popoverPlacement: 'top',
-    listenResize: false,
+    shouldListenForResize: false,
 };
 
 export {propTypes, defaultProps};
diff --git a/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js b/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js
@@ -93,7 +93,7 @@ class BasePaymentsPage extends React.Component {
      */
     paymentMethodPressed(nativeEvent, accountType, account) {
         let position = getClickedElementLocation(nativeEvent);
-        if (this.props.listenResize) {
+        if (this.props.shouldListenForResize) {
             window.addEventListener('resize', () => {
                 position = getClickedElementLocation(nativeEvent);
                 this.setPositionAddPaymentMenu(position);
@@ -168,7 +168,7 @@ class BasePaymentsPage extends React.Component {
      * Hide the add payment modal
      */
     hideAddPaymentMenu() {
-        if (this.props.listenResize) {
+        if (this.props.shouldListenForResize) {
             window.removeEventListener('resize', null);
         }
         this.setState({shouldShowAddPaymentMenu: false});
@@ -178,7 +178,7 @@ class BasePaymentsPage extends React.Component {
      * Hide the default / delete modal
      */
     hideDefaultDeleteMenu() {
-        if (this.props.listenResize) {
+        if (this.props.shouldListenForResize) {
             window.removeEventListener('resize', null);
         }
         this.setState({shouldShowDefaultDeleteMenu: false});

diff --git a/src/pages/settings/Payments/PaymentsPage/index.js b/src/pages/settings/Payments/PaymentsPage/index.js
@@ -2,7 +2,7 @@ import React from 'react';
 import BasePaymentsPage from './BasePaymentsPage';
 
 const PaymentsPage = () => (
-    <BasePaymentsPage listenResize />
+    <BasePaymentsPage shouldListenForResize />
 );
 
 PaymentsPage.displayName = 'PaymentsPage';

diff --git a/src/pages/settings/Payments/PaymentsPage/paymentsPagePropTypes.js b/src/pages/settings/Payments/PaymentsPage/paymentsPagePropTypes.js
@@ -14,7 +14,7 @@ const propTypes = {
     isLoadingPaymentMethods: PropTypes.bool,
 
     /** Listen for window resize event on web and desktop. */
-    listenResize: PropTypes.bool,
+    shouldListenForResize: PropTypes.bool,
 
     ...withLocalizePropTypes,
 
@@ -27,7 +27,7 @@ const defaultProps = {
     },
     betas: [],
     isLoadingPaymentMethods: true,
-    listenResize: false,
+    shouldListenForResize: false,
 };
 
 export {propTypes, defaultProps};