update types

src/components/ReportActionItem/TaskPreview.tsx

@@ -124,6 +124,6 @@ export default withCurrentUserPersonalDetails(
     withOnyx<TaskPreviewProps, TaskPreviewOnyxProps>({
         taskReport: {
             key: ({taskReportID}) => `${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`,
-        }
+        },
     })(TaskPreview),
 );

src/pages/tasks/TaskAssigneeSelectorModal.tsx

@@ -221,7 +221,7 @@ const TaskAssigneeSelectorModalWithOnyx = withOnyx<TaskAssigneeSelectorModalProp
     },
     task: {
         key: ONYXKEYS.TASK,
-    }
+    },
 })(TaskAssigneeSelectorModal);
 
 export default withCurrentUserPersonalDetails(TaskAssigneeSelectorModalWithOnyx);

src/pages/tasks/TaskTitlePage.tsx

@@ -1,7 +1,5 @@
 import React, {useCallback, useRef} from 'react';
 import {View} from 'react-native';
-import {withOnyx} from 'react-native-onyx';
-import type {OnyxEntry} from 'react-native-onyx';
 import FullPageNotFoundView from '@components/BlockingViews/FullPageNotFoundView';
 import FormProvider from '@components/Form/FormProvider';
 import InputWrapper from '@components/Form/InputWrapper';
@@ -21,15 +19,9 @@ import type {WithReportOrNotFoundProps} from '@pages/home/report/withReportOrNot
 import * as Task from '@userActions/Task';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
-import type {Policy, PolicyRole} from '@src/types/onyx';
 import {isEmptyObject} from '@src/types/utils/EmptyObject';
 
-type TaskTitlePageOnyxProps = {
-    /** The policy of parent report */
-    rootParentReportPolicy: OnyxEntry<PolicyRole>;
-};
-
-type TaskTitlePageProps = WithReportOrNotFoundProps & WithCurrentUserPersonalDetailsProps & TaskTitlePageOnyxProps;
+type TaskTitlePageProps = WithReportOrNotFoundProps & WithCurrentUserPersonalDetailsProps;
 
 type Values = {
     title: string;
@@ -39,7 +31,7 @@ type Errors = {
     title?: string;
 };
 
-function TaskTitlePage({report, rootParentReportPolicy, currentUserPersonalDetails}: TaskTitlePageProps) {
+function TaskTitlePage({report, currentUserPersonalDetails}: TaskTitlePageProps) {
     const styles = useThemeStyles();
     const {translate} = useLocalize();
 
@@ -74,7 +66,7 @@ function TaskTitlePage({report, rootParentReportPolicy, currentUserPersonalDetai
 
     const inputRef = useRef<AnimatedTextInputRef | null>(null);
     const isOpen = ReportUtils.isOpenTaskReport(report);
-    const canModifyTask = Task.canModifyTask(report, currentUserPersonalDetails.accountID, rootParentReportPolicy?.role);
+    const canModifyTask = Task.canModifyTask(report, currentUserPersonalDetails.accountID);
     const isTaskNonEditable = ReportUtils.isTaskReport(report) && (!canModifyTask || !isOpen);
 
     return (
@@ -126,16 +118,6 @@ function TaskTitlePage({report, rootParentReportPolicy, currentUserPersonalDetai
 
 TaskTitlePage.displayName = 'TaskTitlePage';
 
-const ComponentWithOnyx = withOnyx<TaskTitlePageProps, TaskTitlePageOnyxProps>({
-    rootParentReportPolicy: {
-        key: ({report}) => {
-            const rootParentReport = ReportUtils.getRootParentReport(report);
-            return `${ONYXKEYS.COLLECTION.POLICY}${rootParentReport ? rootParentReport.policyID : '0'}`;
-        },
-        selector: (policy: OnyxEntry<Policy>) => ({role: policy?.role}),
-    },
-})(TaskTitlePage);
-
-const ComponentWithCurrentUserPersonalDetails = withCurrentUserPersonalDetails(ComponentWithOnyx);
+const ComponentWithCurrentUserPersonalDetails = withCurrentUserPersonalDetails(TaskTitlePage);
 
 export default withReportOrNotFound()(ComponentWithCurrentUserPersonalDetails);

src/types/onyx/Policy.ts

@@ -45,8 +45,6 @@ type Connection = {
 
 type AutoReportingOffset = number | ValueOf<typeof CONST.POLICY.AUTO_REPORTING_OFFSET>;
 
-type PolicyValue = ValueOf<typeof CONST.POLICY.ROLE>;
-
 type Policy = {
     /** The ID of the policy */
     id: string;
@@ -55,7 +53,7 @@ type Policy = {
     name: string;
 
     /** The current user's role in the policy */
-    role: PolicyValue;
+    role: ValueOf<typeof CONST.POLICY.ROLE>;
 
     /** The policy type */
     type: ValueOf<typeof CONST.POLICY.TYPE>;
@@ -177,11 +175,6 @@ type Policy = {
     connections?: Record<string, Connection>;
 };
 
-type PolicyRole = {
-    /** The role of current user */
-    role?: PolicyValue;
-};
-
 export default Policy;
 
-export type {Unit, CustomUnit, PolicyRole};
+export type {Unit, CustomUnit};

src/types/onyx/index.ts

@@ -45,7 +45,6 @@ import type {PersonalDetailsList} from './PersonalDetails';
 import type PersonalDetails from './PersonalDetails';
 import type PlaidData from './PlaidData';
 import type Policy from './Policy';
-import type {PolicyRole} from './Policy';
 import type {PolicyCategories, PolicyCategory} from './PolicyCategory';
 import type {PolicyMembers} from './PolicyMember';
 import type PolicyMember from './PolicyMember';
@@ -125,7 +124,6 @@ export type {
     PersonalDetailsList,
     PlaidData,
     Policy,
-    PolicyRole,
     PolicyCategories,
     PolicyCategory,
     PolicyMember,