Merge pull request #4875 from Expensify/jules-removeGrowlFromVBAFlow

Remove Growl from VBA flow, for non-server errors
Expensify · Aug 27, 2021 · 887778c · 887778c
2 parents 7e926e1 + 60adff6
commit 887778c
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/src/libs/actions/BankAccounts.js b/src/libs/actions/BankAccounts.js
@@ -602,8 +602,18 @@ function validateBankAccount(bankAccountID, validateCode) {
         });
 }
 
-function showBankAccountFormValidationError(error) {
-    Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {error}).then(() => Growl.error(error));
+/**
+ * Set the current error message. Show Growl for server errors as they are not yet handled by the error Modal.
+ *
+ * @param {String} error
+ * @param {Boolean} isServerError
+ */
+function showBankAccountFormValidationError(error, isServerError) {
+    Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {error}).then(() => {
+        if (isServerError) {
+            Growl.error(error);
+        }
+    });
 }
 
 /**
@@ -777,7 +787,7 @@ function setupWithdrawalAccount(data) {
             goToWithdrawalAccountSetupStep(nextStep, achData);
 
             if (error) {
-                showBankAccountFormValidationError(error);
+                showBankAccountFormValidationError(error, true);
             }
         })
         .catch((response) => {