Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/Safari - "Copy URL" option and other options are missing when clicking on any link #10407

Closed
kbecciv opened this issue Aug 16, 2022 · 10 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Aug 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR: #9955

Action Performed:

  1. Launch the app and log in with any account
  2. Send any link (e.g. Google.com) to a chat on web.
  3. Right-click on the link to open the context menu.
  4. Check that you see one option, Copy URL to clipboard on all platforms.
  5. Add an attachment to a chat on the web.
  6. Right-click on the attachment to open the context menu.
  7. Check that you see several options excluding Copy link and Copy to clipboard.

Expected Result:

It should only display the Copy URL to clipboard option when we click any link.

Actual Result:

"Copy URL" option and other options are missing when clicking on any link or image

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2022

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2022

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kevinksullivan kevinksullivan removed their assignment Aug 18, 2022
@kevinksullivan
Copy link
Contributor

Looks like this will be external but going to leave that decision to @amyevans

@amyevans
Copy link
Contributor

Reproduced the issue in mobile Safari, looks good to move to External.

@amyevans amyevans removed their assignment Aug 18, 2022
@amyevans amyevans added the External Added to denote the issue can be worked on by a contributor label Aug 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2022

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@parasharrajat
Copy link
Member

This issue does not make sense.

  1. Images should not have copies to clipboard links as the tests say on Disable Copy link context menu for attachments and url. #9955.
  2. Only links will have these options.

I think Copy Link option is disabled behind beta that's why you are not able to see it.

Another issue is that the mini-menu should not be shown on mobileWeb.

cc: @kevinksullivan

@dylanexpensify
Copy link
Contributor

reviewing today, but seems we're unsure about this one. cc @parasharrajat any thoughts?

@melvin-bot melvin-bot bot removed the Overdue label Aug 22, 2022
@sketchydroide
Copy link
Contributor

like @parasharrajat copy link is no loger supposed to be visible on images, and I think the beta explanation makes sense

@parasharrajat
Copy link
Member

parasharrajat commented Aug 22, 2022

Now the real issue is that Mini-menu should not be shown on the mobile web. It is only for Web and Desktop. Instead on mobile/mWeb, long-pressing should open a bottom menu.

This issue seems like a regression.

@sketchydroide
Copy link
Contributor

yeah the beta is checked here

return Permissions.canUseCommentLinking(betas) && type === CONTEXT_MENU_TYPES.REPORT_ACTION && !isAttachmentTarget;

so I think this is good to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants