Disable Copy link context menu for attachments and url. #9955

Harshdeepjoshi · 2022-07-18T16:24:29Z

Details

Fixed Issues

$ #9660

Tests

Send any link (e.g. Google.com) to a chat on web.
Right-click on the link to open the context menu.
Check that you see one option, Copy URL to clipboard on all platforms.
Add an attachment to a chat on the web.
Right-click on the attachment to open the context menu.
Check that you see several options excluding Copy link and Copy to clipboard.
Right-clicking anywhere other than over the image or PDF attachment will also show the copy link menu.
Right-click on the attachment on android or Ios, also shows copy link menu as well.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Send any link (e.g. Google.com) to a chat on web.
Right-click on the link to open the context menu.
Check that you see one option, Copy URL to clipboard on all platforms.
Add an attachment to a chat on the web.
Right-click on the attachment to open the context menu.
Check that you see several options excluding Copy link and Copy to clipboard.
Right-clicking anywhere other than over the image or PDF attachment will also show the copy link menu.
Right-click on the attachment on android or Ios, also shows copy link menu as well.

Verify that no errors appear in the JS console

Screenshots

Web

URL

Attachment

Mobile Web

URL

Attachment

Desktop

URL

Attachment

iOS

URL

Attachment

Android

URL

Attachment

parasharrajat · 2022-07-18T16:27:43Z

@Harshdeepjoshi Please update the title to more accurately reflect the PR purpose.

src/pages/home/report/ContextMenu/ContextMenuActions.js

Co-authored-by: Rajat Parashar <[email protected]>

Harshdeepjoshi · 2022-07-25T22:13:07Z

Sorry for being late, I was busy with my college examinations.

parasharrajat

IMO, it would be best to do this because an attachment is also and comment and the user might want to use its link.

parasharrajat · 2022-08-04T16:48:31Z

Testing...Code is looking pretty good.

parasharrajat

@Harshdeepjoshi Please update the Tests and QA steps to cover all cases. Then I will approve it.

Send any link (e.g. Google.com) to a chat on web.
Right-click on the link to open the context menu.
Check that you see one option, Copy URL to clipboard on all platforms.
Add an attachment to a chat on the web.
Right-click on the attachment to open the context menu.
Check that you see several options excluding Copy link and Copy to clipboard.
Right-clicking anywhere other than over the image or PDF attachment will also show the copy link menu.
Right-click on the attachment on android or Ios, also shows copy link menu as well.

Harshdeepjoshi · 2022-08-05T19:37:19Z

@parasharrajat Updated tests for all cases.

parasharrajat

LGTM. There are a few issues with contextMenu opening on Native and mWeb but that is not part of this issue.

cc: @sketchydroide

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2022-08-09T10:52:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

dangrous · 2022-12-08T21:21:14Z

Hi! Commenting here as required. I believe this PR caused this issue. In this case, since this was new functionality, I'm guessing that the console error existed and was just not caught in the testing process, although the boxes were checked. So, we should definitely make sure to check all errors in the future! If anyone on this has another idea though of how it got through definitely open to discussing!

0xmiros · 2023-07-14T17:32:09Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            const isAttachment = ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}])));
+
+            // Only hide the copylink menu item when context menu is opened over img element.
+            const isAttachmentTarget = lodashGet(menuTarget, 'tagName') === 'IMG' && isAttachment;


@parasharrajat was there reason to disable copy link for only img tag? What issues you had if isAttachment but not img tag? i.e. doc file

@parasharrajat - Reminder for reply.

@parasharrajat - Any idea ?

More details on #9660 (comment) and the next comments after it. Let me know if you need more clarification.

Update ContextMenuActions.js

9ec59c1

Harshdeepjoshi requested a review from a team as a code owner July 18, 2022 16:24

melvin-bot bot requested review from parasharrajat and sketchydroide and removed request for a team July 18, 2022 16:24

Harshdeepjoshi changed the title ~~Update ContextMenuActions.js~~ Disable Copy link context menu for attachments and url. Jul 18, 2022

parasharrajat suggested changes Jul 18, 2022

View reviewed changes

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

Harshdeepjoshi and others added 2 commits July 26, 2022 03:40

Disable Copy link context menu for attachment suggestion 1

dd51641

Co-authored-by: Rajat Parashar <[email protected]>

Disable Copy link context menu for attachments and url suggestion 2

93f10a2

Co-authored-by: Rajat Parashar <[email protected]>

parasharrajat suggested changes Jul 26, 2022

View reviewed changes

parasharrajat mentioned this pull request Jul 27, 2022

[HOLD #9660] [$250] Copy link option is shown for app links - Reported by @thesahindia #9975

Closed

Harshdeepjoshi added 2 commits August 3, 2022 14:54

disable copy link only on image target.

ebb51ff

Merge branch 'main' of github.com:Expensify/App

1a84291

Harshdeepjoshi force-pushed the main branch from 3e4aac2 to 1a84291 Compare August 3, 2022 09:51

Coments added and remove extra code

1b1879c

parasharrajat suggested changes Aug 5, 2022

View reviewed changes

parasharrajat approved these changes Aug 5, 2022

View reviewed changes

sketchydroide approved these changes Aug 9, 2022

View reviewed changes

sketchydroide merged commit a0c91b9 into Expensify:main Aug 9, 2022

OSBotify mentioned this pull request Aug 15, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

kbecciv mentioned this pull request Aug 16, 2022

iOS/Safari - "Copy URL" option and other options are missing when clicking on any link #10407

Closed

melvin-bot bot mentioned this pull request Aug 23, 2022

[HOLD for payment 2022-08-30] [$250] Right clicking and “Copy Link” on a link produced https://new.expensify.com//r/0/NaN when pasted #9660

Closed

dangrous mentioned this pull request Dec 8, 2022

[HOLD for payment 2022-12-15] [$250] BUG: Web - Console error when comment in a report is right clicked and context menu is opened - reported by @aneequeahmad #11903

Closed

jeet-dhandha mentioned this pull request Jun 22, 2023

[HOLD for payment 2023-09-06] [$1000] mweb - Inconsistency: Copy Link context menu item does not show on the attachment message when it is opened over the attachment in mweb|web #21346

Closed

6 tasks

0xmiros reviewed Jul 14, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Copy link context menu for attachments and url. #9955

Disable Copy link context menu for attachments and url. #9955

Harshdeepjoshi commented Jul 18, 2022 •

edited

Loading

parasharrajat commented Jul 18, 2022

Harshdeepjoshi commented Jul 25, 2022

parasharrajat left a comment

parasharrajat commented Aug 4, 2022

parasharrajat left a comment •

edited

Loading

Harshdeepjoshi commented Aug 5, 2022 •

edited

Loading

parasharrajat left a comment

OSBotify commented Aug 9, 2022

dangrous commented Dec 8, 2022

0xmiros Jul 14, 2023

jeet-dhandha Jul 20, 2023

jeet-dhandha Aug 7, 2023

parasharrajat Aug 8, 2023 •

edited

Loading

Disable Copy link context menu for attachments and url. #9955

Disable Copy link context menu for attachments and url. #9955

Conversation

Harshdeepjoshi commented Jul 18, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

URL

Attachment

Mobile Web

URL

Attachment

Desktop

URL

Attachment

iOS

URL

Attachment

Android

URL

Attachment

parasharrajat commented Jul 18, 2022

Harshdeepjoshi commented Jul 25, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat commented Aug 4, 2022

parasharrajat left a comment • edited Loading

Choose a reason for hiding this comment

Harshdeepjoshi commented Aug 5, 2022 • edited Loading

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

OSBotify commented Aug 9, 2022

dangrous commented Dec 8, 2022

0xmiros Jul 14, 2023

Choose a reason for hiding this comment

jeet-dhandha Jul 20, 2023

Choose a reason for hiding this comment

jeet-dhandha Aug 7, 2023

Choose a reason for hiding this comment

parasharrajat Aug 8, 2023 • edited Loading

Choose a reason for hiding this comment

Harshdeepjoshi commented Jul 18, 2022 •

edited

Loading

parasharrajat left a comment •

edited

Loading

Harshdeepjoshi commented Aug 5, 2022 •

edited

Loading

parasharrajat Aug 8, 2023 •

edited

Loading