[HOLD for payment 2022-10-20] [$250] Android/IOS - Attachment - PDF file is not shown in Preview Page, only 0.00% is shown

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app and log in with account
2. Select any user
3. Tab on plus button
4. Select Add attachment
5. Select Chose from Documents
6. Select any PDF file and tap Send
7. Open the PDF file again

Expected Result:

PDF file is shown in Preview Page

Actual Result:

PDF file is not shown in Preview Page

Workaround:

Unknkown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.88.14

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any accounts

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Upwork job URL: https://www.upwork.com/jobs/~01eda72888fdccc636

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[techievivek]

@kbecciv I am unable to reproduce this either locally or on staging. Is there a specific file size or any constraint that gets applied here because uploading a small-size pdf file doesn't help us reproduce this?

[kbecciv]

@techievivek Checking with Team, will update you shortly

[kbecciv]

@techievivek This issue is reproduced in Android app, please attached PDF file.
I am unable to reproduce this issue in Web/Chrome.

change.pdf

Screen_Recording_20220818-133526_Files.mp4

[kbecciv]

@techievivek Attaching IOS behavior for this issue

Image.from.iOS.50.MP4

[kakajann]

Proposal

The error is:

Error: ReactNativeBlobUtil request error: java.lang.IllegalStateException: Use of own trust manager but none definedjava.lang.IllegalStateException: Use of own trust manager but none defined

simply adding this prop trustAllCerts={false} will fix this issue.

App/src/components/PDFView/index.native.js

Lines 35 to 41 in a72f85a

	<PDF
	activityIndicator={<FullScreenLoadingIndicator />}
	source={{uri: props.sourceURL}}
	style={[
	styles.imageModalPDF,
	StyleUtils.getWidthAndHeightStyle(props.windowWidth, props.windowHeight),
	]}

Before	After

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[techievivek]

@kevinksullivan We already discussed about this issue here so we will be just moving forward with the @kakajann

[techievivek]

Not overdue, have posted it in slack for any contributor manager to have a look.

[kakajann]

Am I eligible for contributor payment?

[techievivek]

Yes, @kakajann you are. Let's wait till Monday and then I will bring this to team.

[techievivek]

Have posted in #product for some thoughts on the above point.

[michaelhaxhiu]

Note, vivek posted in an internal expensify slack channel here (#product) and we'll follow up as soon as we have next steps.

[Santhosh-Sellavel]

Cool thanks!

[techievivek]

Hi @michaelhaxhiu we have come to an agreement that we would like to use an activity indicator rather than a percentage-based approach so I think we are good to go with the proposal.

[Santhosh-Sellavel]

Good then, thanks!

[melvin-bot]

@kakajann, @michaelhaxhiu, @techievivek, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

PR is merged waiting for deployment!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Attachment load negative percentage #11200

If no regressions arise, payment will be issued on 2022-10-20. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[michaelhaxhiu]

Excellent, thanks for the check @mvtglobally. I'll prep payment.

1. @kakajann is already hired via https://www.upwork.com/jobs/~01eda72888fdccc636, but that job link expired and so I'll make a new one for @Santhosh-Sellavel to apply to below:

2. @Santhosh-Sellavel can you apply to this new job - https://www.upwork.com/jobs/~014caa50546908ac6a

[michaelhaxhiu]

1/2 paid... just need to get santhosh now :)

[kakajann]

I solved 2 issues btw

[michaelhaxhiu]

@kakajann can you point me to both for clarity? If this is true, you can apply to the 2nd job link I made for Santhosh (above). But let's first get on the same page before proceeding.

[kakajann]

@michaelhaxhiu here's context #10442 (comment)

[kakajann]

#10465

#11200

[michaelhaxhiu]

Thanks for sharing. In this case, I agree and buddy checked with @techievivek in a DM.

I think you are due $500 ($250 for each independent fix) and @Santhosh-Sellavel is due $250 for C+ reviewing one of those fixes (the other fix was reviewed by internal expensify staff).

[michaelhaxhiu]

All paid.