PAID [$250] [Bug] - error message out of screen reported by @gadhiyamanan

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to OldDot
2. create account
3. create free policy
4. click on it
5. go to workspace
6. connect bank account
7. Go to Workspace > connect bank account
8. check error message

Expected Result:

error message should not be out of screen

Actual Result:

error message out of screen

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.2.10 - 0
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Simulator.Screen.Recording.-.iPhone.13.mini.-.2022-08-25.at.16.06.09.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661423805265769

View all open jobs on GitHub

[mnosov622]

Hello @kavimuru !

Can you assign this issue to me, please ?

I would love to fix this bug.

[gadhiyamanan]

Proposal

use style={[styles.mutedTextLabel, styles.flex1]} instead of style={styles.mutedTextLabel}

App/src/pages/ReimbursementAccount/BankAccountStep.js

Lines 145 to 147 in 38b1d84

	<Text style={styles.mutedTextLabel}>
	{props.translate('bankAccount.validateAccountError')}
	</Text>

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[gadhiyamanan]

@kavimuru no one assigned here

[kavimuru]

@mnosov622 I have assigned now. @gadhiyamanan I didn't assign as it needed a reproduction.

[mnosov622]

Hi !

Thank you.

[kavimuru]

@mnosov622 Needs a reproduction. I couldn't reproduce.

[mnosov622]

Oh, okay

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

@tjferriss 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[tjferriss]

Unable to reproduce. Asked in Slack thread to confirm if issue is still happening for others.

[tjferriss]

I'm not able to reproduce as I don't have a simulator or a real business bank account to add in order to get this error message. @gadhiyamanan is reporting they can see still see the bug, so I'm going to pass this over to engineering.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.26-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Error message floating out of screen IOS/Android Fix #12552

If no regressions arise, payment will be issued on 2022-11-18. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[laurenreidexpensify]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed: -

• [@marcochavezf @Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: a224f66
• [@marcochavezf @Santhosh-Sellavel The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/PAID [$250] [Bug] - error message out of screen reported by @gadhiyamanan #11488#issuecomment-1302274426
• [@marcochavezf @Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/244873
• [@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.

[Santhosh-Sellavel]

The offending PR is incorrect @laurenreidexpensify

[laurenreidexpensify]

Yes sorry Copy Pasta 🍝 mistake 🤦‍♀️

[laurenreidexpensify]

@Santhosh-Sellavel @gadhiyamanan @syedsaroshfarrukhdot payment has been sent in Upwork 👍

[syedsaroshfarrukhdot]

@laurenreidexpensify Am I eligible for the 50% bonus for this issue as my PR was merged in 1day after being assigned ?

[laurenreidexpensify]

LGTM @syedsaroshfarrukhdot, issued bonus 👍

[syedsaroshfarrukhdot]

LGTM @syedsaroshfarrukhdot, issued bonus 👍

Thank You

[Santhosh-Sellavel]

@laurenreidexpensify I didn't get paid!

[Santhosh-Sellavel]

@laurenreidexpensify bump!

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[laurenreidexpensify]

@Santhosh-Sellavel huge apols!! missed this- paying now!

[laurenreidexpensify]

Looking into adding this to TestRail here https://expensify.slack.com/archives/C01SKUP7QR0/p1669217672801509

[Santhosh-Sellavel]

@laurenreidexpensify I received only $125 bonus, didn’t receive the payment $250 for the job!

[laurenreidexpensify]

@Santhosh-Sellavel huge apols!!!! I have corrected this now.