Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#admins rooms tied to Collect or Control policies not showing in search or LHN for assigned Guides #11991

Closed
MitchExpensify opened this issue Oct 19, 2022 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Oct 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Note: (How do I test 121 assigned guides on dev?)

  1. Non paying user creates a Collect or Control policy and is assigned a Guide (Guide gets added as a policy admin)
  2. The #admins room tied to that policy shows in LHN for the Guide logged in New.expensify using their team.expensify.com account
  3. The Guide uses the search feature in NewDot, typing the policy name, to find the #admins room of the Collect or Control policy

Expected Result:

  1. The #admins room tied to the Collect or Control policy shows in LHN for the Guide logged in new.expensify using their team.expensify.com account
  2. The #admins room tied to the Collect or Control policy is discoverable via search for the Guide logged in new.expensify using their team.expensify.com account

Actual Result:

  1. The #admins room tied to the Collect or Control policy does not show in LHN for the Guide logged in new.expensify using their team.expensify.com account
  2. The #admins room tied to the Collect or Control policy is not discoverable via search for the Guide logged in new.expensify using their team.expensify.com account

Workaround:

They can find assignments be logging into expensify.com and looking at their policies list. They can then follow up via email.

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number:
Reproducible in staging?:
Reproducible in production?: Yes
Email or phone of affected tester (no customers):

Guides:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Customers:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
image

image

Issue reported by: Mitch
Slack conversation: Reports from Guides here and more reports from Guides here

View all open jobs on GitHub

@MitchExpensify MitchExpensify added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2022

Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 19, 2022
@MitchExpensify
Copy link
Contributor Author

cc @alex-mechler for thoughts on this as he is one of the closest to the code

@MitchExpensify
Copy link
Contributor Author

Asked if this is a fire here - https://expensify.slack.com/archives/C03U7DCU4/p1666201675400019

@alex-mechler
Copy link
Contributor

1:1'd Puneet, taking this over since I think i know what is happening here

@alex-mechler alex-mechler added Improvement Item broken or needs improvement. Engineering labels Oct 19, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@alex-mechler alex-mechler added the Reviewing Has a PR in review label Oct 19, 2022
@melvin-bot melvin-bot bot closed this as completed Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants