Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - App crashes when login #12037

Closed
kavimuru opened this issue Oct 20, 2022 · 17 comments
Closed

Web - App crashes when login #12037

kavimuru opened this issue Oct 20, 2022 · 17 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Oct 20, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to NewDot
  2. Your account needs to have a default room
  3. Enter email and password and click "Sign in "

Expected Result:

User is able to login successfully

Actual Result:

App crashes

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Desktop

Version Number: 1.2.18-2
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers): [email protected], [email protected], [email protected]. Password: Test1234 [email protected] / Feya86Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5784964_RPReplay_Final1666190117__1_.mp4

https://user-images.githubusercontent.com/43996225/196963131-5046de5e-450c-472d-b4f2-d693a77f0b01.mp4
new

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666250636656419
https://expensify.slack.com/archives/C01GTK53T8Q/p1666253733144749
https://expensify.slack.com/archives/C01GTK53T8Q/p1666271735578619
https://expensify.slack.com/archives/C01GTK53T8Q/p1666215056542569

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 20, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@trjExpensify
Copy link
Contributor

@mountiny
Copy link
Contributor

PR is up and in review.

@melvin-bot melvin-bot bot closed this as completed Oct 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@alex-mechler
Copy link
Contributor

^ from me mentioning this issue in the other one

@mallenexpensify
Copy link
Contributor

Is this issue specific to Expensify Guides only? I had issues logging in yesterday, was getting blank page, but I haven't seen any other non-guides reporting that

@mountiny
Copy link
Contributor

Is this issue specific to Expensify Guides only? I had issues logging in yesterday, was getting blank page, but I haven't seen any other non-guides reporting that

This happens to anyone who had default rooms/admins rooms

@trjExpensify
Copy link
Contributor

It's if you have default rooms. Fix has been CP'd to staging though now.

@mallenexpensify
Copy link
Contributor

Thanks. I wasn't able to reproduce on production for my [email protected] and [email protected] accounts. I think mine issue was random af ¯_(ツ)_/¯

@mallenexpensify
Copy link
Contributor

hmmm...
signed out of my test account on chrome, staging.new.expensify.com
signed back into test account
:loading_circle_of_doom:
image

refresh and hard refresh are working

@mallenexpensify
Copy link
Contributor

Also, same is happening on firefox for staging.new.expensify.com

@mallenexpensify
Copy link
Contributor

Reopening cuz if

Fix has been CP'd to staging though now.

It should be working, right?

@mallenexpensify
Copy link
Contributor

And... both now loading after refresh :)
And... both now loading without needing to refresh :ohnothing:

@mallenexpensify
Copy link
Contributor

NOPE! hahahahaah
image

Errors in logs
image

image

@mountiny
Copy link
Contributor

@mallenexpensify Can you please do a new issue for this, it is a different error

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants