[HOLD for payment 2022-12-05] Empty chat screen appears with welcome message after login

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings > Sign out
2. Sign in with the same account

Expected Result:

Page opens with chat loaded on the RHN where it was left before logout

Actual Result:

Empty chat screen with welcome message appears

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.31-5
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

12608.Web.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia / Applause internal team
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669298063601539

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I'm unable to reproduce this

[luacmartins]

@mvtglobally the team can't reproduce it. Would you mind checking again?

[luacmartins]

I was just able to reproduce this

I see this console error An error occurred while applying merge for key: report_3473132785054582, Error: TypeError: Cannot convert undefined or null to object and the response from OpenApp is:

jsonCode: 407
message: "Your session has expired. Please sign in again."
requestID: "76f430588efc4214-SJC"
title: "Session expired"

Which is weird because we just signed in so the AuthToken shouldn't be expired

[luacmartins]

Tried again and this time I got An error occurred while applying merge for key: report_3473132785054582, Error: TypeError: Cannot convert undefined or null to object and OpenReport response has value: null which makes sense since report_3473132785054582 is an IOU report and won't have a reportAction history

[luacmartins]

This seems to be an API issue, investigating

[luacmartins]

Fix up here #13028

[sophiepintoraetz]

Speedy work, thanks Carlos! Let me know if you need me at all here

[luacmartins]

Nope this is all done! The PR is merged and we are CPing the fix at this moment, so I'll close this issue.

[thesahindia]

@sophiepintoraetz, this is eligible for the reporting compensation.

[luacmartins]

@thesahindia sorry, I missed that. Reopening!

[luacmartins]

@sophiepintoraetz could you please pay the reporting bonus to @thesahindia?

[luacmartins]

Removing deploy blocker label since this was fixed and I just reopened to pay the bonus!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Only navigate to chat reports #13028

If no regressions arise, payment will be issued on 2022-12-05. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/Web-Expensify/pull/35594
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/Web-Expensify/pull/35594#issuecomment-1334621410
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this was just an order of events issue since the fix was planned but on a later PR.
• [@sophiepintoraetz] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[thesahindia]

@sophiepintoraetz could you please pay the reporting bonus to @thesahindia?

Bump @sophiepintoraetz

[sophiepintoraetz]

Thanks @thesahindia - I think I've hired you directly but here's the job link

[thesahindia]

Accepted, thanks!

[luacmartins]

@thesahindia @sophiepintoraetz are we good to close this issue?

[thesahindia]

@luacmartins, payment is pending.

cc: @sophiepintoraetz

[sophiepintoraetz]

@thesahindia - paid!

Also @luacmartins - we've got this to do before we can close out the issue

[luacmartins]

@sophiepintoraetz checklist done!

[sophiepintoraetz]

Coolio - looks like we're sorted here! I don't think we need to add a regression test given that we had a fix planned!