Log in - "Account closed successfully" message does not disappear until put your log in and click continue.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch App and login
2. Navigate to security > Close account
3. Enter your default contact method
4. Tap on "Close account" button
   5.Confirm the "Account closed successfully" message displays correctly
5. Start typing new email address under log in page

Expected Result:

"Account closed successfully" message should be disappear after start typing new email address

Actual Result:

"Account closed successfully" message does not disappear until put your log in and tap continue.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.38.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1861.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

Issue is not reproduced in production, attached video

Recording.1860.mp4

[markarmanus]

Proposal:

Issue:

We set the onyx data for ONEXKEYS.FORMS.CLOSE_ACCOUNT_FORM to be true when the request succeds and we never reset its value.

Solution:
The same way we are reseting account errors when the user starts typing with this code.

        if (this.props.account.errors) {
            Session.clearAccountMessages();
        }

We do the same thing with the account close data.

We create this function which resets the data

function resetAccountCloseData() {
    Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, CONST.DEFAULT_CLOSE_ACCOUNT_DATA);
}

Then we use that function on user input to the email field.

if (this.props.closeAccount.success) {
    Session.resetAccountCloseData();
}

Here is the full diff

diff --git a/src/libs/actions/Session/index.js b/src/libs/actions/Session/index.js
index 13f1eadc5..4dd01d52f 100644
--- a/src/libs/actions/Session/index.js
+++ b/src/libs/actions/Session/index.js
@@ -388,6 +388,9 @@ function clearAccountMessages() {
         isLoading: false,
     });
 }
+function resetAccountCloseData() {
+    Onyx.merge(ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM, CONST.DEFAULT_CLOSE_ACCOUNT_DATA);
+}
 
 /**
  * Calls change password and signs if successful. Otherwise, we request a new magic link
@@ -578,6 +581,7 @@ export {
     clearSignInData,
     cleanupSession,
     clearAccountMessages,
+    resetAccountCloseData,
     validateEmail,
     authenticatePusher,
     reauthenticatePusher,
diff --git a/src/pages/signin/LoginForm.js b/src/pages/signin/LoginForm.js
index e9813c3bf..bf6ec680b 100755
--- a/src/pages/signin/LoginForm.js
+++ b/src/pages/signin/LoginForm.js
@@ -111,6 +111,9 @@ class LoginForm extends React.Component {
         if (this.props.account.errors) {
             Session.clearAccountMessages();
         }
+        if (this.props.closeAccount.success) {
+            Session.resetAccountCloseData();
+        }
     }
 
     /**

Video:

Screen.Recording.2022-12-10.at.9.51.48.PM.mov

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Gonals]

Grabbing this one for #urgency

[mallenexpensify]

Thanks for snagging this @Gonals , I'm going to hang tight as BZ for now, let me know if you need help testing or anything.

[chiragsalian]

Qa tested the CP PR and its a pass, removing deploy blocker label

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Stop displaying Closed Account message when the user starts typing #13519

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR: Display message to user when account is closed #11665
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Display message to user when account is closed #11665 (comment)
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1671097654324829
• [@mallenexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  https://github.com/Expensify/Expensify/issues/249401

[mallenexpensify]

Testing to see if can close without checking boxes up top

[mallenexpensify]

Looks like it, not sure need to address
#13506 (comment)