[HOLD for payment 2023-01-16] Workspace name is truncated even though there is enough space to fill

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a new long name workspace if you don't have one
2. Go to Settings > Workspaces
3. Observe the long workspace name is truncated

Expected Result:

Workspace name should not be truncated when there is still enough space

Actual Result:

Workspace name is truncated

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari (resizing the browser)
• MacOS / Desktop (resizing the browser)

Version Number: v1.2.48-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672827523060149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017bc707bc39462f98
• Upwork Job ID: 1611127456696561664
• Last Price Increase: 2023-01-05

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017bc707bc39462f98

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[luacmartins]

PR up!

[Pujan92]

Have doubt, is this needs to consider for the general MenuItems or only for Workspace List?
IMO it should apply to all and 1 more usecase is here

diff --git a/src/styles/styles.js b/src/styles/styles.js
index 82e9ca8f2..46964ec1d 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -1119,7 +1119,6 @@ const styles = {
     popoverMenuText: {
         fontSize: variables.fontSizeNormal,
         color: themeColors.heading,
-        maxWidth: 240,
     },

[mananjadhav]

Thanks for raising this @Pujan92. I think this can be worked as a separate issue. While the change looks small enough, the MenuItem component is used at several places. We will have test all those components for an unrelated change.

But if @luacmartins thinks we can add in this PR, I am fine with that too.

[luacmartins]

I considered that, but dismissed it for the same reasons @mananjadhav mentioned. However, it seems like the PR that introduced the fixed width did so to truncate long workspace names. So it might be safe to remove this. I'll come back to test this after the deploy is done!

[mananjadhav]

@miljakljajic Can you help me with the payout here? This has crossed the regression period. Been on production for 7 days.

cc - @luacmartins

[mananjadhav]

@miljakljajic Quick bump.

[miljakljajic]

Paying immediately!

[miljakljajic]

Please accept the offer when you have a chance.

[mananjadhav]

Thank you so much @miljakljajic. Accepted

[bernhardoj]

May I have your help too for the reporting bonus? @miljakljajic

[miljakljajic]

Of course! I paid you your bonus @bernhardoj and sent payment to you, @mananjadhav. Thank you for your patience and apologies for the delay.

[mananjadhav]

Thanks @miljakljajic for the help here

[bernhardoj]

@miljakljajic Thank you!