-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim long workspace name #4835
Trim long workspace name #4835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, tested in web / android.
Hello @akshayasalvi, Any QA tests needed for this PR? |
Yes, @isagoico. QA is needed. |
Looking good. I have one outstanding question which I asked here on the issue. |
Oh this was already merged... 😄 |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
@akshayasalvi when creating new PRs, can you please include the full link to the GH issue and not just the issue number? |
Okay noted. Will do. |
@Julesssss Can you please review this?
Details
Fixed Issues
$ #4747
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android