Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-01-26 #14604

Closed
13 tasks done
OSBotify opened this issue Jan 26, 2023 · 10 comments
Closed
13 tasks done

Deploy Checklist: New Expensify 2023-01-26 #14604

OSBotify opened this issue Jan 26, 2023 · 10 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 26, 2023

Release Version: 1.2.60-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 26, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 26, 2023
@luacmartins luacmartins self-assigned this Jan 26, 2023
@luacmartins luacmartins added the Daily KSv2 label Jan 26, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.60-0 🚀

@mvtglobally
Copy link

@luacmartins @roryabraham
Regression is completed

#12370 is failing #14621
PR #12447 is failing #14622
#14478 we are blocked as we can't reach terms without the valid SSN it seems
image - 2023-01-27T103701 501

@luacmartins
Copy link
Contributor

@luacmartins
Copy link
Contributor

I'll check #12447 off since it's a small UI issue and we have the same behavior in production. I can work on a fix for it though.

input.mov

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.60-1 🚀

@luacmartins
Copy link
Contributor

@mvtglobally
Copy link

#14628 Web/Desktop/mWeb Pass.
Waiting for Native app builds

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.60-1 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

I tested #14628 and it's a pass!

@luacmartins
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants