Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security - An input field looks strange without border #14613

Closed
6 tasks
kbecciv opened this issue Jan 27, 2023 · 3 comments
Closed
6 tasks

Security - An input field looks strange without border #14613

kbecciv opened this issue Jan 27, 2023 · 3 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jan 27, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Settings - > Security -> Close account
  4. Write a long test to the feedback input field

Expected Result:

The placeholder text should be closer to the border

Actual Result:

An input field looks strange without bordure

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.60.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5913153_Recording__3543.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 27, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 27, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@robertjchen robertjchen removed the DeployBlockerCash This issue or pull request should block deployment label Jan 27, 2023
@robertjchen
Copy link
Contributor

I think this is expected based on my read of the input field style changes here: #12447 cc: @Luke9389

Feel free to re-open if not the case!

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 27, 2023

I'm not sure if it should have that height. We'll need to take a look at that. There's another issue open for this one though.

#14609

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants