[HOLD for payment 2023-03-13] [$1000] Language picker texts are not same at login page and preferences.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Sign in to https://staging.new.expensify.com in the Mac/iOS/Android Chrome or Safari browser
2. Click on Profile > Preferences > change the language to Spanish
3. Sign out
4. Notice the drop-down language on the sign-in page isn't in Spanish

Expected Result:

If your language Preference is Spanish, you should see Spanish on the sign-in page.

Actual Result:

Showing English on the sign-in page when the language is Spanish

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.74-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1558.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676731178309489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f95903e9a3bdc10d
• Upwork Job ID: 1627913032303964160
• Last Price Increase: 2023-02-23

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

• I don't understand what we are expecting to see
• Asking for clarification in the Slack convo - https://expensify.slack.com/archives/C049HHMV9SM/p1676870867653159?thread_ts=1676731178.309489&cid=C049HHMV9SM

[Christinadobrzyn]

• Updated the troubleshooting steps based on the Slack convo
• I don't think it's the same issue but a related issue regarding Country/Language here [HOLD for payment 2023-03-17] [$4000] Add translations for State & Country Pickers #14549
• I don't think [HOLD for payment 2023-03-17] [$4000] Add translations for State & Country Pickers #14549 impedes working on this job and I think this can be done Externally so adding label for review. cc @Beamanator just for a check

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f95903e9a3bdc10d

[MelvinBot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jatinsonijs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Language picker is not consistent across app. In login page it do not changes values based on selected language but in Language preference it is changing based on selected language.

What is the root cause of that problem?

As per slack discussion - values should be as per selected language same as preference page.
In login page we are displaying values based on there language not as per user selected language.

App/src/components/LocalePicker.js

Line 29 in 660e389

const localesToLanguages = {

What changes do you think we should make in order to solve the problem?

We can do same way as in Preference page:

App/src/pages/settings/Preferences/LanguagePage.js

Line 25 in 660e389

const localesToLanguages = _.map(props.translate('languagePage.languages'),

Here we just need 2 fields value and text, we have to rename field text to label. and need to use it inside the component.

What alternative solutions did you explore? (Optional)

None

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The languagePicker texts are not according the to the selected locale.

What is the root cause of that problem?

In the this file:

App/src/components/LocalePicker.js

Lines 29 to 38 in a5b9c9b

	const localesToLanguages = {
	default: {
	value: 'en',
	label: Localize.translate('en', 'languagePage.languages.en.label'),
	},
	es: {
	value: 'es',
	label: Localize.translate('es', 'languagePage.languages.es.label'),
	},
	};

We are setting the label as Localize.translate('es', 'languagePage');

What changes do you think we should make in order to solve the problem?

Instead of hardcoding the locale like this in the Localize.translate method, we should use the preferredLocale provided by withLocalize and then pass that locale to the Localize.translate method

After solution

Screen.Recording.2023-02-20.at.1.46.35.AM.mov

[Milos213]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Locale picker dropdown items text on Login page and options text on Language preference page are not consistent.
Former one uses equivalent language, while latter one uses selected language

What is the root cause of that problem?

App/src/languages/en.js

Lines 530 to 540 in 660e389

	languagePage: {
	language: 'Language',
	languages: {
	en: {
	label: 'English',
	},
	es: {
	label: 'Spanish',
	},
	},
	},

On Language preference page, localized text is used, which depend on preferred locale user selected.

App/src/pages/settings/Preferences/LanguagePage.js

Lines 25 to 29 in 660e389

	const localesToLanguages = _.map(props.translate('languagePage.languages'),
	(language, key) => (
	{
	value: key,
	text: language.label,

What changes do you think we should make in order to solve the problem?

Use static text (not depend on preferred locale) instead of localized text (depend on preferred locale)
For this, we should use Localize.translate instead of withLocalize & props.translate

                text: Localize.translate(key, `languagePage.languages.${key}.label`),

This approach is already used in LocalePicker for signin page:

App/src/components/LocalePicker.js

Lines 29 to 38 in 660e389

	const localesToLanguages = {
	default: {
	value: 'en',
	label: Localize.translate('en', 'languagePage.languages.en.label'),
	},
	es: {
	value: 'es',
	label: Localize.translate('es', 'languagePage.languages.es.label'),
	},
	};

[Beamanator]

@Christinadobrzyn I agree with your thoughts here 👍 :

• I don't think [$2000] Add translations for State & Country Pickers #14549 impedes working on this job and I think this can be done Externally so adding label for review. cc @Beamanator just for a check

[MelvinBot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[MelvinBot]

Upwork job price has been updated to $1000

[Christinadobrzyn]

Sorry I accidentally removed the [$1000] in the GH title - added it back!

[rushatgabhane]

ok all solutions are good. just in a choice paralysis of which one to go with lol

[MelvinBot]

@rushatgabhane, @Christinadobrzyn, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

📣 @jatinsonijs You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jatinsonijs]

PR is ready for review

cc @rushatgabhane

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[aldo-expensify]

Issue not reproducible during KI retests. (First week)

How is this issue being tested? I still see the languages in the list not translated to the selected language:

[Milos213]

I think that's the expected behavior (equivalent language, not selected language). And on preferences page, it should also look like this, which is my proposal:

Let's say user doesn't know English but only Spanish. If selected language is English, user doesn't know which is Spanish from dropdown menu. User knows Espanol but doesn't know Spanish 😄

[MelvinBot]

📣 @Milos213! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[aldo-expensify]

I think that's the expected behavior (equivalent language, not selected language). And on preferences page, it should also look like this, which is my proposal:

Let's say user doesn't know English but only Spanish. If selected language is English, user doesn't know which is Spanish from dropdown menu. User knows Espanol but doesn't know Spanish 😄

This crossed my mind too and I consider it a valid alternative, but I understand from the slack conversation that we decided that the expected behaviour would be to show the options in the current picked language, not the language of the option itself (preferences page behaviour).

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add dynamic language options and translate locale picker #15553

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jatinsonijs] Propose regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/269493

[jatinsonijs]

Regression Test Proposal

1. Logout if already logged in.
2. From locale / language picker change the language.
3. Open the locale picker again.
4. Verify locale picker values are also translated based on selected language.

[Christinadobrzyn]

Paying this out - looks like this was merged within 3 days so the bonus will be included in the payment

Oh my, so sorry it looks like I haven't yet hired @jatinsonijs and @rushatgabhane for this.

• @jatinsonijs you'll get a reporter bonus ($250) & a 50% bonus
• @rushatgabhane you'll get the 50% bonus

Can you both please accept my job offer in Upwork and I'll pay you? Upwork job here - https://www.upwork.com/jobs/~01f95903e9a3bdc10d

[rushatgabhane]

Accepted, thanks!

[Christinadobrzyn]

Paid @rushatgabhane $1000 + 50% bonus!
Paid @jatinsonijs $1000 + $250 reporting + 50% bonus!

Closed job in upwork, working on the regression test.

[Christinadobrzyn]

Regression test buddy check - https://expensify.slack.com/archives/C01SKUP7QR0/p1678982816023959

[Christinadobrzyn]

Sound like we don't need to do a buddy check on this. So I'm going to send it to QA for them to figure out a spot in Test Rail.