[HOLD for payment 2023-03-21] Extra comma in search placeholder text and Terms of service appears in connect bank account page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open search and observe placeholder text in english
3. Change language from settings->preferences to spanish
4. Open search and observe placeholder text in spanish
5. Open connect bank account
6. Open connect manually
7. On step 1, observe the checkbox link text

Expected Result:

Placeholder text on search should say 'Name, email or phone number' in english (without comma after email).
In step 7, Checkbox link in connect bank account step 1 should say 'Expensify Terms of Service' (with capital S)

Actual Result:

Placeholder text on search says 'Name, email, or phone number' in english (wrong grammer i.e. comma after email). Checkbox link in connect bank account step 1 says 'Expensify Terms of service'

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

3.small.issues.as.one.mp4

Recording.1629.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677927250728619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba1ae7334694dfc5
• Upwork Job ID: 1632787967198875648
• Last Price Increase: 2023-03-06

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

I don't agree that , or is an issue. Posted in the slack thread.

The Terms of service should definitely be Terms of Service.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba1ae7334694dfc5

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[MelvinBot]

@puneetlath, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Capitalize Terms of Service #15686

If no regressions arise, payment will be issued on 2023-03-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @dhanashree-sawant
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR @eVoloshchak

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @puneetlath] The PR that introduced the bug has been identified. Link to the PR: Update capitalization of copy to match new guidelines #4854
• [@eVoloshchak / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update capitalization of copy to match new guidelines #4854 (comment)
• [@eVoloshchak / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a nothing to discuss
• [@puneetlath] Determine if we should create a regression test for the bug. No
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@puneetlath] Review the proposed regression test steps and location.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@dhanashree-sawant can you please apply to the job here: https://www.upwork.com/jobs/~01ba1ae7334694dfc5

[dhanashree-sawant]

Hi @puneetlath , thanks I have applied to the job.

[puneetlath]

All paid. Thanks everyone!