Update capitalization of copy to match new guidelines #4854
Conversation
| companyWebsite: 'Página web de la empresa', | ||
| taxIDNumber: 'Número de identificación fiscal', | ||
| companyType: 'Tipo de empresa', |
There was a problem hiding this comment.
These translations were wrong, so I also fixed them
iwiznia
changed the title
iwiznia
changed the title
|
We want to merge with tests ongoing? |
Nooooo, I can merge when tests are done. |
There was a problem hiding this comment.
Left a few suggestions. Great work @iwiznia! My eyes are very happy now 😄
Co-authored-by: Carlos Martins <[email protected]>
|
Wow, so many I missed... updated, can you re-review please |
|
@MonilBhavsar merge at will |
|
Looks like the conflicts started already! 😭 |
|
Once conflicts are resolved, we need to merge it asap. |
|
Updated |
|
Going OOO next week, so if this conflicts again before you can merge it, can someone take care of resolving them and getting it merged please? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @MonilBhavsar in version: 1.0.88-3 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
|
FYI: we changed the |
Fixed Issues
$https://github.com/Expensify/Expensify/issues/169061
Tests
Click around on the site both in spanish and english and make sure the capitalization of the copy is correct. We should only capitalize names, the beginning of sentences and acronyms.
QA Steps
Same, but please try to be on the lookout for any capitalization we missed
Tested On
Screenshots