Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-06-15] [Navigation Reboot] Update RHP to be encapsulated in another navigator #15848

Closed
mountiny opened this issue Mar 10, 2023 · 23 comments
Closed

[HOLD for payment 2023-06-15] [Navigation Reboot] Update RHP to be encapsulated in another navigator #15848

mountiny opened this issue Mar 10, 2023 · 23 comments
Assignees
@mountiny @adamgrzybowski
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 10, 2023 •
edited by melvin-bot bot
Loading

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Update the right modal to be encapsulated in another navigator.

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011dc9881a445d34df
  • Upwork Job ID: 1634919787249025024
  • Last Price Increase: 2023-03-12
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@mountiny mountiny mentioned this issue Mar 10, 2023
Closed
7 tasks
@adamgrzybowski
Copy link
Contributor

Going to implement this

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~011dc9881a445d34df

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@mountiny
Copy link
Contributor Author

Not overdue, gonna be implementing this week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2023
@mountiny
Copy link
Contributor Author

@adamgrzybowski can you please leave a comment daily on each of the daily issues with an update (so they dont go overdue)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 16, 2023
@mountiny
Copy link
Contributor Author

ECX is over, work resumes.

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@adamgrzybowski
Copy link
Contributor

I was working on this today. I will do some more tests tomorrow and create a PR

@mountiny
Copy link
Contributor Author

Unassigning CPlus for now, I will ask in the channel once the PR will be ready

@melvin-bot melvin-bot bot added the Overdue label Mar 23, 2023
@adamgrzybowski
Copy link
Contributor

Still working on this. It's not that easy to create separate PR just for this issue so the Implementation will be pushed in a single PR including:

#15848
#15851
#15852

@melvin-bot melvin-bot bot removed the Overdue label Mar 23, 2023
This was referenced Mar 23, 2023
Closed
Closed
@melvin-bot melvin-bot bot added the Overdue label Mar 23, 2023
@mountiny
Copy link
Contributor Author

Actively being worked on

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 24, 2023
@mountiny
Copy link
Contributor Author

Lets create the draft PR even if its not ready for review yet 🙌

@melvin-bot melvin-bot bot removed the Overdue label Mar 27, 2023
@parasharrajat
Copy link
Member

parasharrajat commented Mar 27, 2023 •
edited
Loading

@mountiny If you need a C+ review, please assign me back 😄 .

@mountiny
Copy link
Contributor Author

@parasharrajat sure!

@adamgrzybowski adamgrzybowski mentioned this issue Mar 27, 2023
Merged
55 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 27, 2023
@MelvinBot
Copy link

@mountiny, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

mountiny commented Apr 4, 2023

Not overdue, PR is being worked on

@MelvinBot
Copy link

@mountiny, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

Actively being worked on

@MelvinBot
Copy link

@mountiny, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

Actively being worked on

@mountiny
Copy link
Contributor Author

Good to close

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Reboot] Update RHP to be encapsulated in another navigator [HOLD for payment 2023-06-15] [Navigation Reboot] Update RHP to be encapsulated in another navigator Jun 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

@adamgrzybowski adamgrzybowski

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MelvinBot @parasharrajat @mountiny @adamgrzybowski