Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-03-13 #15889

Closed
16 tasks done
OSBotify opened this issue Mar 13, 2023 · 14 comments
Closed
16 tasks done

Deploy Checklist: New Expensify 2023-03-13 #15889

OSBotify opened this issue Mar 13, 2023 · 14 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 13, 2023

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 13, 2023
@Julesssss Julesssss self-assigned this Mar 13, 2023
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.83-1 🚀

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 13, 2023
@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.83-1 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

Julesssss commented Mar 13, 2023

Hey @Expensify/mobile-deployers, @jasperhuangg has a pretty critical PR to deploy (context). it would be very helpful if you had a moment to InternalQA any of these issues to help speed up deployment once this PR is CP'd (need to head out as it's past 6pm here)

@Julesssss
Copy link
Contributor

Also, @Expensify/applauseleads, it would be much appreciated if we can check off these items asap. Thanks!

@mvtglobally
Copy link

@Julesssss Team is working on the regression. We still have around 80% to go. I will try to speed it up, but we are definitely quite a few hours away from deploy

@jasperhuangg
Copy link
Contributor

@mvtglobally Are you saying there's other work before we finish checking off QA here before we can deploy?

@mvtglobally
Copy link

@jasperhuangg,
Along with the checklist PRs above, we run a very extensive TestRail regression (over 1000TCs) to verify that deploy did not break any existing functionality. We started just a few hrs ago, so there is still a lot of work to be done there

@jasperhuangg
Copy link
Contributor

Gotcha

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.83-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.83-2 has been deployed to staging 🎉

@mvtglobally
Copy link

@Julesssss @jasperhuangg
Regressions is completed

Blockers
#15915
#15918

#15897, we do not have Android build yet. Rest platforms pass

@jasperhuangg
Copy link
Contributor

@mvtglobally I checked/will check off both the deploy blockers:

#15915 was deemed not a deploy blocker by @neil-marcellini
#15918 I have a fix that's being deployed to staging right now

@jasperhuangg
Copy link
Contributor

Checking off #15918, we deployed a fix in #15923 and I just tested it successfully!

@roryabraham
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants