Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - App is crashed when clicking on View all receipts and other option while Offline #15918

Closed
2 of 6 tasks
kbecciv opened this issue Mar 13, 2023 · 10 comments
Closed
2 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with a HIGH TRAFFIC account.
  3. After login in with a High Traffic account - enable Airplane mode to simulate a connection loss
  4. Go to the following options and click on them
    4.1 Reimburse expenses/ View all receipts
    4.2 Pay bill/ View all bills
    4.3 Send Invoices/ Send Invoice and View all invoices

Expected Result:

App is not crashed

Actual Result:

App is crashed when clicking on View all receipts and other option while Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.83.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5976266_Offline_Workspaceissue.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 13, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 13, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg jasperhuangg self-assigned this Mar 13, 2023
@jasperhuangg
Copy link
Contributor

@thienlnam gonna swoop in here to help out since this blocks the deploy of my PR for ECX stuff

@jasperhuangg
Copy link
Contributor

caused by lack of offline testing from PR #11614, fix incoming...

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 13, 2023
@jasperhuangg
Copy link
Contributor

#15923

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Mar 14, 2023
@melvin-bot melvin-bot bot changed the title Workspace - App is crashed when clicking on View all receipts and other option while Offline [HOLD for payment 2023-03-21] Workspace - App is crashed when clicking on View all receipts and other option while Offline Mar 14, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 14, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@Julesssss
Copy link
Contributor

Removing the blocker label as the fix has been deployed and I have verified the fix

@Julesssss
Copy link
Contributor

Closing as there is no reporter to pay

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Mar 15, 2023
@Julesssss Julesssss changed the title [HOLD for payment 2023-03-21] Workspace - App is crashed when clicking on View all receipts and other option while Offline Workspace - App is crashed when clicking on View all receipts and other option while Offline Mar 15, 2023
@Julesssss Julesssss removed the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 15, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 15, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Mar 15, 2023
@melvin-bot melvin-bot bot changed the title Workspace - App is crashed when clicking on View all receipts and other option while Offline [HOLD for payment 2023-03-22] Workspace - App is crashed when clicking on View all receipts and other option while Offline Mar 15, 2023
@MelvinBot

This comment was marked as off-topic.

@Julesssss Julesssss removed the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 15, 2023
@Julesssss Julesssss changed the title [HOLD for payment 2023-03-22] Workspace - App is crashed when clicking on View all receipts and other option while Offline Workspace - App is crashed when clicking on View all receipts and other option while Offline Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants