Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-03-14 #15938

Closed
7 tasks done
OSBotify opened this issue Mar 14, 2023 · 9 comments
Closed
7 tasks done

Deploy Checklist: New Expensify 2023-03-14 #15938

OSBotify opened this issue Mar 14, 2023 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 14, 2023

Release Version: 1.2.84-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 14, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 14, 2023
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.84-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.84-1 has been deployed to staging 🎉

@Julesssss Julesssss self-assigned this Mar 14, 2023
@Julesssss
Copy link
Contributor

Hey @Expensify/applauseleads, just wanted to check in as I have about an hour left in my day. Let me know if I can help with anything!

@Julesssss
Copy link
Contributor

Heading out now but I'll be resolving any remaining issues and deploying first thing tomorrow morning 👍

@mvtglobally
Copy link

Regression is completed

@Julesssss
Copy link
Contributor

I checked off #15918 as the fix was deployed to prod and I have verified the fix.

@Julesssss
Copy link
Contributor

No new crashes whatsoever in Firebase 🤩

@Julesssss
Copy link
Contributor

No noticeable regression in the app timing dashboard 👍

@Julesssss
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants