Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-08-02] [$250] Migrate BaseKeyboardSpacer.js to function component #16173

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 72 comments
Closed
1 task

[HOLD for payment 2023-08-02] [$250] Migrate BaseKeyboardSpacer.js to function component #16173

marcaaron opened this issue Mar 20, 2023 · 72 comments
Assignees
@slafortune @cristipaval @mollfpr @vadymbokatov
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ca21614168991470
  • Upwork Job ID: 1678836792784138240
  • Last Price Increase: 2023-07-11
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate BaseKeyboardSpacer.js to function component [HOLD][$250] Migrate BaseKeyboardSpacer.js to function component Apr 13, 2023
@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this issue?

@marcaaron marcaaron changed the title [HOLD][$250] Migrate BaseKeyboardSpacer.js to function component [$250] Migrate BaseKeyboardSpacer.js to function component Jul 11, 2023
@marcaaron marcaaron added Daily KSv2 NewFeature Something to build that is a new item. External Added to denote the issue can be worked on by a contributor labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ca21614168991470

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @slafortune (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

📣 @vadymbokatov You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@vadymbokatov
Copy link
Contributor

vadymbokatov commented Jul 12, 2023 •
edited
Loading

Thank you for assigning me this task to me.
I have submitted my proposal on upwork.
I will create PR by tomorrow.

@vadymbokatov vadymbokatov mentioned this issue Jul 12, 2023
Closed
58 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 12, 2023
@vadymbokatov vadymbokatov mentioned this issue Jul 14, 2023
Merged
58 tasks
@vadymbokatov
Copy link
Contributor

vadymbokatov commented Jul 19, 2023 •
edited
Loading

Hi, team. Please review my PR. Thank you.
#22886

@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @vadymbokatov got assigned: 2023-07-12 16:56:13 Z
  • when the PR got merged: 2023-07-24 18:11:27 UTC
  • days elapsed: 8

On to the next one 🚀

@cristipaval
Copy link
Contributor

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @vadymbokatov got assigned: 2023-07-12 16:56:13 Z
  • when the PR got merged: 2023-07-24 18:11:27 UTC
  • days elapsed: 8

On to the next one 🚀

@slafortune The PR was ready to review but it took longer because I was ooo last week.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 26, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate BaseKeyboardSpacer.js to function component [HOLD for payment 2023-08-02] [$250] Migrate BaseKeyboardSpacer.js to function component Jul 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023 •
edited by slafortune
Loading

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 1, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Aug 3, 2023

Friendly bump @slafortune for payment.

@slafortune
Copy link
Contributor

Sorry for the delay @mollfpr - Paid 👍
@vadymbokatov - offer sent!

@vadymbokatov
Copy link
Contributor

@slafortune Accepted offer.

@slafortune
Copy link
Contributor

All paid! Bonus sent separate.

@vadymbokatov
Copy link
Contributor

Thank you

@alpeshl alpeshl mentioned this issue Aug 9, 2023
Closed
1 task
@slafortune
Copy link
Contributor

The bonus was paid in error on this. Migration issues do not qualify for a speedy bonus - some of the reasoning is it doesn’t apply because these migrations are not fixing any bugs, so whether it’s merged in 1 or 7 days, it doesn’t have any effect on the product.

@vadymbokatov
Copy link
Contributor

@slafortune Oh. This is my first commit for this project. I didn't know that rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slafortune slafortune

@cristipaval cristipaval

@mollfpr mollfpr

@vadymbokatov vadymbokatov

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests