Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-07-26] [$250] Migrate withEnvironment.js to function component #16220

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 68 comments
Closed
1 task

[HOLD for payment 2023-07-26] [$250] Migrate withEnvironment.js to function component #16220

marcaaron opened this issue Mar 20, 2023 · 68 comments
Assignees
@anmurali @s77rt @stitesExpensify @alpeshl
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018506175ea9f2e1ae
  • Upwork Job ID: 1678837647976857600
  • Last Price Increase: 2023-07-11
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate withEnvironment.js to function component [HOLD][$250] Migrate withEnvironment.js to function component Apr 13, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 6, 2023
@dummy-1111
Copy link
Contributor

I'd love to work on this.

@muxriddinmuqimov77
Copy link

I'd like to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Jun 22, 2023
@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@marcaaron marcaaron changed the title [HOLD][$250] Migrate withEnvironment.js to function component [$250] Migrate withEnvironment.js to function component Jul 11, 2023
@marcaaron marcaaron added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Jul 11, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018506175ea9f2e1ae

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jul 19, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate withEnvironment.js to function component [HOLD for payment 2023-07-26] [$250] Migrate withEnvironment.js to function component Jul 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 25, 2023
@alpeshl
Copy link
Contributor

alpeshl commented Jul 31, 2023

bump for payment reminder

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 31, 2023
@alpeshl
Copy link
Contributor

alpeshl commented Aug 3, 2023

Gentle reminder for payment due!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 8, 2023

@anmurali, @s77rt, @stitesExpensify, @alpeshl Huh... This is 4 days overdue. Who can take care of this?

@PhantomOz
Copy link

@anmurali, @s77rt, @stitesExpensify, @alpeshl Huh... This is 4 days overdue. Who can take care of this?

I can take care of this @stitesExpensify @alpeshl @anmurali @s77rt

@anmurali
Copy link

anmurali commented Aug 9, 2023 •
edited
Loading

Payments

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2023
@s77rt
Copy link
Contributor

s77rt commented Aug 9, 2023

@anmurali Speed bonus does not apply for functional migration issues. I have refunded the +50%.

@alpeshl
Copy link
Contributor

alpeshl commented Aug 9, 2023

@anmurali Speed bonus does not apply for functional migration issues. I have refunded the +50%.

@s77rt why? I see bonus was paid here for migration #16173 (comment)

@s77rt
Copy link
Contributor

s77rt commented Aug 9, 2023

@alpeshl That seems to be a mistake. AFAIK those type of issues do not qualify for speed bonus.

@alpeshl
Copy link
Contributor

alpeshl commented Aug 9, 2023

@alpeshl That seems to be a mistake. AFAIK those type of issues do not qualify for speed bonus.

Idk. but I think every contribution should be fairly same for everyone. TBH, I had put extended effort to speed up progress on this to be eligible for speed bonus.

@melvin-bot melvin-bot bot added the Overdue label Aug 11, 2023
@anmurali
Copy link

If the process is not to pay a speed bonus for these issues, then that's that. Every issue should be worked on with #urgency regardless of bonus! Everyone has been paid now.

@melvin-bot melvin-bot bot removed the Overdue label Aug 15, 2023
@alpeshl
Copy link
Contributor

alpeshl commented Sep 4, 2023

@anmurali upwork job contract shows as active.
https://www.upwork.com/nx/wm/workroom/34491868/overview

Can you please end the contract?

@alpeshl
Copy link
Contributor

alpeshl commented Oct 9, 2023

@anmurali bump for ☝️

@alpeshl
Copy link
Contributor

alpeshl commented Oct 12, 2023

@anmurali Gentle reminder!

@alpeshl
Copy link
Contributor

alpeshl commented Nov 23, 2023 •
edited
Loading

@anmurali @stitesExpensify
This ticket was completed long back but upwork job contract was not updated. Could you please help to close upwork job.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anmurali anmurali

@s77rt s77rt

@stitesExpensify stitesExpensify

@alpeshl alpeshl

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests