Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Workspace name reverts back to previous one after some time #17185

Closed
6 tasks done
kbecciv opened this issue Apr 8, 2023 · 13 comments
Closed
6 tasks done
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a workspace
  3. Rename workspace

Expected Result:

New workspace name be displayed until it is changed again

Actual Result:

Workspace name reverts back to previous one after some time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6010784_video_46.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f611310e55512079
  • Upwork Job ID: 1645507115317637120
  • Last Price Increase: 2023-04-10
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@francoisl
Copy link
Contributor

This is happening on production too. If you rename a workspace and refresh the page, it reverts to the old name.

Screen.Recording.2023-04-10.at.10.37.29.AM.mov

Going to remove the blocker label for now.

@francoisl francoisl added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 10, 2023
@roryabraham
Copy link
Contributor

Interestingly, I'm able to reproduce this on staging but not locally. Maybe I need to update my local API...

@roryabraham
Copy link
Contributor

Ok, updating the API is what was needed to reproduce this, which tells me this was broken in the back-end and needs to be internal.

@roryabraham roryabraham added the Internal Requires API changes or must be handled by Expensify staff label Apr 10, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01f611310e55512079

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2023
@roryabraham
Copy link
Contributor

I don't think I'll need a C+ review here since it will be a back-end fix.

@roryabraham
Copy link
Contributor

@roryabraham
Copy link
Contributor

@bondydaa
Copy link
Contributor

I think this is already patched on https://github.com/Expensify/Web-Expensify/pull/37121/, you can test against staging it only changing the policy/workspace name will actually happen.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 4, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @roryabraham, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@roryabraham
Copy link
Contributor

Confirmed this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants