[HOLD for payment 2023-05-16] [$1000] Make LHN Preview for Archived chats consistent

[mountiny]

Coming from here

### Problem

Currently the preview of archived chats contains the last message sent, except if the chat is a policy expense chat. If it’s a policy expense chat, it will show the reason for the archive reason, ex: This workspace chat is no longer active because is no longer an active workspace.. This causes difference in behavior for no apparent reason, since both types of chats can have content.
In the images below there’s the before and after the workspace deletion, where all chats had content. Note that only the non policy expense chat contain the last message preview.

### Solution

Use the same behaviour for all chats, so that it is consistent.

1. If there is some message before the room/ policy expense chat has been archived, show that message
2. If there is no message in the archived chat, show the Closed report action message. ie This workspace has been archived because XYZ But this message will be trimmed in the preview.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c1f0e5d8fc4290e0
• Upwork Job ID: 1646456802523676672
• Last Price Increase: 2023-04-13

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

cc @BeeMargarida

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

Hello, Ana from Callstack here, I can pick this up!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c1f0e5d8fc4290e0

[MelvinBot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

📣 @BeeMargarida You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

This is on hold for #17363 as now the archived chats dont show 😢

[mountiny]

@BeeMargarida This is off hold now, the archived chats should be accessible in the LHN

[BeeMargarida]

This is off hold now, the archived chats should be accessible in the LHN

Will tackle it next!

[BeeMargarida]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No consistency between archived rooms preview, archived rooms and policy expense chats show different things.

What is the root cause of that problem?

There is different logic for when a report is a policy expense chat:

App/src/libs/SidebarUtils.js

Line 284 in c144663

if (result.isPolicyExpenseChat && result.isArchivedRoom) {

When it's a policy expense chat, it shows the archived reason, even if there is a last message.

What changes do you think we should make in order to solve the problem?

Change the check mentioned above so that it only checks if a room is archived and there is no last message.

From result.isPolicyExpenseChat && result.isArchivedRoom to result.isArchivedRoom && lastMessageText.length === 0.

Also, it will be necessary to change the check below that changes the preview text to No Activity yet if the last message is empty. This should only run if the message is empty and the chat is not archived.

From result.isChatRoom || result.isPolicyExpenseChat to (result.isChatRoom || result.isPolicyExpenseChat) && !result.isArchivedRoom.

The first change can be applied in OptionsListUtils.js, since we don't want different behaviour between 'default' rooms and policy expense chats.
However, the other check can't be applied since there's extra logic in OptionsListUtils.js that allows forcing the preview to be the chat room subtitle (ex: policy name or 'workspace') or other things (ex: user preview).

What alternative solutions did you explore? (Optional)

--

[mountiny]

Seems fine to me, any concern @rushatgabhane?

[mountiny]

Thank you very much, I have left a review

[MelvinBot]

@BeeMargarida, @rushatgabhane, @mountiny, @sophiepintoraetz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[BeeMargarida]

Update: Currently being tested internally by QA

[m4rtag]

RETESTS SUMMARY

This fix is verified on Branch PR Draft *BeeMargarida:fix/17386-consistent_lhn_preview_for_archived_chats 

Tests are conducted on the following devices:
Google Chrome Version 112.0.5615.121 (Official Build) (arm64) at Mac OS Ventura 13.3.1
Safari Version 16.4 (18615.1.26.11.23) at Mac OS Ventura 13.3.1
Expensify Desktop app - New Expensify Electron Version v1.3.1-0, Electron Version 22.3.6 (22.3.6)
iOS native app - iPhone Simulator Version 14.2 (986.5), iOS 16.2, SimulatorKit 627, CoreSimulator 885.2
Safari on iOS - iPhone Simulator 14 iOS 16.2
Android native app v1.3.1-0 - Android Emulator -Nexus_5X_API_TiramisuPrivacySandbox:5554
Chrome 101.0.4951.74, Operating system Android13; Build/TRA4.221021.001.B1 

*As the fix does not meet Solution requirements it is returned to the developer for further investigation

[MelvinBot]

📣 @m4rtag! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[m4rtag]

Actually, my comment above is obsolete due to newer arrangements, the screenshot can be found below.

The above tests are executed with a 100% pass value and may be released onto stage

chat.description.mp4

change.of.description.after.log.out.and.back.in.mp4

[BeeMargarida]

Udpate: PR is ready for review

[rushatgabhane]

Unassigning because @parasharrajat is reviewing the PR

[melvin-bot]

📣 @parasharrajat You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Getting closer with the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: consistent lhn preview for archived chats #18019

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[parasharrajat]

This is a feature request.

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: NA
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA

[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sophiepintoraetz]

All right - I think the only payment due here, should no regressions arise, are $1000 to @parasharrajat - correct? (No timeline bonus applied where callstack are assigned as the contributor)

[mountiny]

I think thats correct, thanks!

[sophiepintoraetz]

All right - contract has been sent! Job is here https://www.upwork.com/jobs/~011fbafcc7f6b88173?frkscc=YaCOyt4kvnp5. (N.B. I am at a conference, Rajat so it may take a little longer to approve payment - only by a day or so!)

[parasharrajat]

No worries. Accepted the offer @sophiepintoraetz.