[$1000] Expensify Help website color code and caret icons are not updated

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://help.expensify.com/

Expected Result:

LHN color, border color and text color should get updated as in ND color values

Actual Result:

Not adjusted and caret icons are also to be updated.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.193.mp4

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681136382590979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c6ce94e5c5aaf840
• Upwork Job ID: 1645759871931166720
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[shawnborton]

Assigning myself too to help with making sure the correct colors are chosen.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c6ce94e5c5aaf840

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help page's color palette is not consistent with NewDot.

What is the root cause of that problem?

1. The colors defined in _colors.scss and their usage in _main.scss is not consistent with NewDot color palette.

caret icons are also to be updated

The arrow icons in the Help site is using default font-awesome icons as can be seen here

App/docs/_includes/lhn-template.html

Line 42 in c1a2b23

<i class="fa-solid fa-angle-right icon"></i>

(the fa-angle-xxx)

What changes do you think we should make in order to solve the problem?

Here're the inconsistencies listed in the OP and the corresponding fix:
a. LHN color: currently set here, needs to be updated to the greenHighlightBackground in NewDot

App/src/styles/colors.js

Line 25 in d196a12

greenHighlightBackground: '#07271F',

b. LHN border color: currently set here, needs to be updated to the greenBorders in NewDot

App/src/styles/colors.js

Line 26 in d196a12

greenBorders: '#1A3D32',

c. Text color: page-wide should be updated to the white color in NewDot

App/src/styles/colors.js

Line 30 in d196a12

white: '#E7ECE9',

Similar updates should be done with the rest of the inconsistencies like the link hover color, ... (which are missed in the issue OP) if we want to fix it as part of this issue.

2. The arrow icons need to be updated to use <svg> tag, with our NewDot arrow svgs, for example the ArrowRight svg in NewDot here https://github.com/Expensify/App/blob/main/assets/images/arrow-right.svg.

We need to replace all instances of the fa-angle arrow icons with our svgs from NewDot, we need to do the same for other inconsistent icons if applicable as well.

What alternative solutions did you explore? (Optional)

NA

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MahmudjonToraqulov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help website color code and caret icons are not updated

What is the root cause of that problem?

.fa-angle-down should be added color: white property

What changes do you think we should make in order to solve the problem?

.fa-angle-down should be added color: white property in style.css file

What alternative solutions did you explore? (Optional)

N/A

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help website color code and caret icons are not updated

What is the root cause of that problem?

This caused because of old color values in https://github.com/Expensify/App/blob/d196a1217754ffab2e10ba28ba3c88f0b6391bf5/docs/_sass/_colors.scss
And usage of font awesome icons for caret

What changes do you think we should make in order to solve the problem?

We can update values in _colors.scss file to have updated color values, here is something I have achieved in small amount of time

Regarding caret icon, we can change it to use new dot svg icon, but It will break consistency of using font awesome for help pages, and might clutter up html files with svg. But we can update color values and size of caret icon to match new dot design(in above image).

What alternative solutions did you explore? (Optional)

[shawnborton]

Hey everyone - just wanted to help guide the proposals here.

For the caret icon, we should be using the same svg we use in the /App repo.

For the colors, we just need to update them to match the colors found here and here

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help website color code and caret icons are not updated

What is the root cause of that problem?

Component hasn't been updated in a long time, not consistent with design changes.

What changes do you think we should make in order to solve the problem?

We need to update the colors in the colors.scss file. This has the be consistent with the ND colors defined in colors.js.

Other than that, we need to update the caret icon that is used throughout the app to instead use the Expensify caret icon, included in assets/images/arrow-right.svg. This will be done by replacing all occurences of the fa-angle-right font awesome icon with the ND svg.

In addition to this, we also need to do the following:

• Replace all occurences of fa-angle-down with the svg used in ND, assets/images/arrow-down.svg
• Replace all occurences of fa-angle-up with the svg used in ND, assets/images/arrow-up.svg
• Replace all occurences of fa-angle-left with the svg used in ND, assets/images/arrow-left.svg
• Remove the to be unused icon style

  App/docs/_sass/_main.scss

  Lines 493 to 495 in 0763be5

  	&.fa-angle-right {
  	padding-left: 4px;
  	}

[Victor-Nyagudi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help website color code and caret icons are not updated

What is the root cause of that problem?

The Expensify help website uses Font Awesome icons while the Expensify App uses icons from the /assets/images folder.

The container housing the icon and text on the help website, when selected, is given a class of selected that turns the text inside white. However, this style doesn't cascade down to the icon element.

<div class="icon-with-link selected">
    <i class="fa-solid fa-angle-down icon">...</i>
    <span>Request money</span>
</div>

App/docs/_sass/_main.scss

Lines 274 to 278 in 8adee6b

	.selected {
	cursor: auto;
	font-weight: bold;
	color: $color-white;
	}

What changes do you think we should make in order to solve the problem?

I would add a descendant selector to the current setup inside _main.scss to also make the caret white when its parent container is selected.

.icon-with-link {
    display: grid;
    grid-template-columns: 40px auto;
    cursor: pointer;

    &.selected .fa-angle-down {
        color: $color-white
    }
}

What alternative solutions did you explore? (Optional)

Hey everyone - just wanted to help guide the proposals here.

For the caret icon, we should be using the same svg we use in the /App repo.

For the colors, we just need to update them to match the colors found here and here

@shawnborton stated in an earlier comment that the caret icons used should be the ones inside the /App repo, therefore, the icons used in the Expensify Help website would need to be replaced with the ones in the /assets/images folder.

Secondly, I observed using React Developer Tools on Chrome that these icons, arrow right at least, receive a fill, height, and width prop, so we can then pass the $color-white variable (the one currently in use on the help website) obtained from _colors.scss to the fill prop, when the option in the LHN is selected, to turn the icon white.

This will potentially include using an isSelected variable or something similar to determine what color is passed to the icon when an option is selected or unselected.

[Santhosh-Sellavel]

@puneetlath The first proposal from @dukenv0307 looks good to get started.

But other proposals looks good for contention here with some details
From @alitoshmatov #17238 (comment)

And they have the following concerns as well

Regarding caret icon, we can change it to use new dot svg icon, but It will break consistency of using font awesome for help pages, and might clutter up html files with svg. But we can update color values and size of caret icon to match new dot design(in above image).

Are we good with above?

---

Other one From @Prince-Mendiratta #17238 (comment)

Final one from @Victor-Nyagudi the here suggesting to add fill for icon on selection. #17238 (comment)

@puneetlath Let me know your thoughts here?

[puneetlath]

I think it's fine for us to use svgs instead of the font-awesome icons. Agreed @shawnborton?

If so, I'm also good with @dukenv0307's proposal.

[shawnborton]

Yup, fontawesome is an external icon library that isn't part of our brand. We should use our own brand icons, which we already have available as svgs. We already have the caret icon in place, we just need to update the svg.

[puneetlath]

Cool, let's go with @dukenv0307 then. Thanks everyone!

[MelvinBot]

📣 @dukenv0307 You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[MelvinBot]

@puneetlath, @shawnborton, @Santhosh-Sellavel, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Santhosh-Sellavel]

Close to merge!

[MelvinBot]

@puneetlath, @shawnborton, @Santhosh-Sellavel, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

Oh weird. This actually went live a week ago. Looks like Melvin didn't properly update the issue.

[Santhosh-Sellavel]

Yes, I was about to comment the same!

[puneetlath]

@dukenv0307 can you apply here? https://www.upwork.com/jobs/~01c6ce94e5c5aaf840

@Santhosh-Sellavel sent you a contract.

[puneetlath]

@Santhosh-Sellavel has been paid.

@dukenv0307 let me know when you've applied.

[dukenv0307]

@puneetlath I've applied, thanks!

[puneetlath]

@dukenv0307 you still need to accept the contract offer. Then I can pay it.

[dukenv0307]

@puneetlath accepted!

[puneetlath]

All paid!